Issue 10882037: libjingle roll r175

Issue 10882037: libjingle roll r175 (Closed)

Created:
8 years, 4 months ago by Mallinath (Gone from Chromium)

Modified:
8 years, 3 months ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, jam, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, joi+watch-content_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

More Reviews

Description

Updating chrome to libjingle r174

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -8 lines)			Patch
M	DEPS	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/p2p/port_allocator.cc	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	remoting/client/plugin/pepper_port_allocator.cc	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	third_party/libjingle/README.chromium	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/libjingle/libjingle.gyp	View	1 2	2 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

lgtm https://chromiumcodereview.appspot.com/10882037/diff/4001/content/renderer/p2p/port_allocator.cc File content/renderer/p2p/port_allocator.cc (right): https://chromiumcodereview.appspot.com/10882037/diff/4001/content/renderer/p2p/port_allocator.cc#newcode294 content/renderer/p2p/port_allocator.cc:294: new cricket::PortConfiguration(stun_server_address_, "", ""); Are these username and ...

8 years, 4 months ago (2012-08-24 19:54:32 UTC) #2

Sergey Ulanov

Also please update CL description to match the revision number that you are rolling

8 years, 4 months ago (2012-08-24 19:55:04 UTC) #3

Mallinath (Gone from Chromium)

On 2012/08/24 19:55:04, sergeyu wrote: > Also please update CL description to match the revision ...

8 years, 4 months ago (2012-08-24 21:16:52 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mallinath@chromium.org/10882037/4001

8 years, 4 months ago (2012-08-25 01:17:25 UTC) #5

commit-bot: I haz the power

Try job failure for 10882037-4001 (retry) on mac for step "compile" (clobber build). It's a ...

8 years, 4 months ago (2012-08-25 01:35:18 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mallinath@chromium.org/10882037/4003

8 years, 4 months ago (2012-08-25 15:54:09 UTC) #7

Change committed as 153413

Expand Messages | Collapse Messages