Issue 10882020: [net/udp] Close events and invalidate handles when UDPSocketWin is closed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10882020: [net/udp] Close events and invalidate handles when UDPSocketWin is closed (Closed)

Created:
8 years, 4 months ago by szym

Modified:
8 years, 3 months ago

Reviewers:
Sergey Ulanov, wtc

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[net/udp] Close events and invalidate handles when UDPSocketWin is closed BUG=121085 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153417

Patch Set 1 #

Patch Set 2 : add check that the socket is still open #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	net/udp/udp_socket_win.cc	View	1	2 chunks	+6 lines, -0 lines	1 comment	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

szym

On 2012/08/24 18:24:25, sergeyu wrote: > lgtm Thanks. I also added: CHECK_NE(INVALID_SOCKET, socket_); before the ...

8 years, 4 months ago (2012-08-24 18:54:40 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szym@chromium.org/10882020/6002

8 years, 4 months ago (2012-08-26 01:37:15 UTC) #5

wtc

8 years, 3 months ago (2012-08-28 00:19:42 UTC) #7

Patch set 2 LGTM.

Can you find out if this class also needs a Core class like
TCPClientSocketWin does?  Thanks.

https://chromiumcodereview.appspot.com/10882020/diff/6002/net/udp/udp_socket_...
File net/udp/udp_socket_win.cc (right):

https://chromiumcodereview.appspot.com/10882020/diff/6002/net/udp/udp_socket_...
net/udp/udp_socket_win.cc:436: AssertEventNotSignaled(write_overlapped_.hEvent);

Should we also add a
    CHECK_NE(INVALID_SOCKET, socket_);
call before this line, as you did on line 387?

Expand Messages | Collapse Messages