Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 10882017: contacts: Make GoogleContactStore own GDataContactsService. (Closed)

Created:
8 years, 4 months ago by Daniel Erat
Modified:
8 years, 4 months ago
Reviewers:
satorux1, kochi
CC:
chromium-reviews, nkostylev+watch_chromium.org, derat+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

contacts: Make GoogleContactStore own GDataContactsService. GDataContactsService used to be instantiated by GDataSystemService, but the latter class is being renamed to be Drive-specific. This change moves GDataContactsService downstream to GoogleContactStore, its only consumer. BUG=128805 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153290

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -20 lines) Patch
M chrome/browser/chromeos/contacts/google_contact_store.h View 2 chunks +5 lines, -4 lines 2 comments Download
M chrome/browser/chromeos/contacts/google_contact_store.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_system_service.h View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_system_service.cc View 4 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Daniel Erat
8 years, 4 months ago (2012-08-23 20:22:15 UTC) #1
kochi
LGTM Thanks for making this change to remove the dependency from GoogleContsctsService to GDataSystemService. I'll ...
8 years, 4 months ago (2012-08-24 01:40:51 UTC) #2
Daniel Erat
https://chromiumcodereview.appspot.com/10882017/diff/1/chrome/browser/chromeos/contacts/google_contact_store.h File chrome/browser/chromeos/contacts/google_contact_store.h (right): https://chromiumcodereview.appspot.com/10882017/diff/1/chrome/browser/chromeos/contacts/google_contact_store.h#newcode148 chrome/browser/chromeos/contacts/google_contact_store.h:148: scoped_ptr<gdata::GDataContactsServiceInterface> gdata_service_; On 2012/08/24 01:40:51, Takayoshi Kochi wrote: > ...
8 years, 4 months ago (2012-08-24 16:52:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/10882017/1
8 years, 4 months ago (2012-08-24 16:52:58 UTC) #4
commit-bot: I haz the power
Try job failure for 10882017-1 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 4 months ago (2012-08-24 18:31:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/10882017/1
8 years, 4 months ago (2012-08-24 18:37:51 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-24 21:24:40 UTC) #7
Change committed as 153290

Powered by Google App Engine
This is Rietveld 408576698