contacts: Make GoogleContactStore own GDataContactsService.

contacts: Make GoogleContactStore own GDataContactsService.

GDataContactsService used to be instantiated by
GDataSystemService, but the latter class is being renamed to
be Drive-specific.  This change moves GDataContactsService
downstream to GoogleContactStore, its only consumer.

BUG=128805
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153290

[kochi, 2012-08-24 01:40:51]

LGTM

Thanks for making this change to remove the dependency
from GoogleContsctsService to GDataSystemService.

I'll wait for this to land and then rebase
https://chromiumcodereview.appspot.com/10873026/

https://chromiumcodereview.appspot.com/10882017/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/contacts/google_contact_store.h (right):

https://chromiumcodereview.appspot.com/10882017/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/contacts/google_contact_store.h:148:
scoped_ptr<gdata::GDataContactsServiceInterface> gdata_service_;
Maybe contacts_service_ a better name?

[Daniel Erat, 2012-08-24 16:52:30]

https://chromiumcodereview.appspot.com/10882017/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/contacts/google_contact_store.h (right):

https://chromiumcodereview.appspot.com/10882017/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/contacts/google_contact_store.h:148:
scoped_ptr<gdata::GDataContactsServiceInterface> gdata_service_;
On 2012/08/24 01:40:51, Takayoshi Kochi wrote:
> Maybe contacts_service_ a better name?

I think I still prefer leaving gdata in the name -- everything here is
contacts-related, so "contacts service" actually isn't very descriptive.

[commit-bot: I haz the power, 2012-08-24 16:52:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/10882017/1

[commit-bot: I haz the power, 2012-08-24 18:31:33]

Try job failure for 10882017-1 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-08-24 18:37:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/10882017/1

[commit-bot: I haz the power, 2012-08-24 21:24:40]

Change committed as 153290