Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: runtime/vm/class_finalizer.cc

Issue 10882007: Re-enable checking of native resolvers. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/class_finalizer.cc
===================================================================
--- runtime/vm/class_finalizer.cc (revision 11203)
+++ runtime/vm/class_finalizer.cc (working copy)
@@ -1080,21 +1080,6 @@
if (cls.is_const()) {
CheckForLegalConstClass(cls);
}
- // Check to ensure we don't have classes with native fields in libraries
- // which do not have a native resolver.
- // TODO(regis): Re-enable native resolver checking after Dartium is fixed.
- if (false && cls.num_native_fields() != 0) {
- const Library& lib = Library::Handle(cls.library());
- if (lib.native_entry_resolver() == NULL) {
- const String& cls_name = String::Handle(cls.Name());
- const String& lib_name = String::Handle(lib.url());
- const Script& script = Script::Handle(cls.script());
- ReportError(script, cls.token_pos(),
- "class '%s' is trying to extend a native fields class, "
- "but library '%s' has no native resolvers",
- cls_name.ToCString(), lib_name.ToCString());
- }
- }
// Add this class to the direct subclasses of the superclass, unless the
// superclass is Object.
if (!super_type.IsNull() && !super_type.IsObjectType()) {
« no previous file with comments | « runtime/tests/vm/vm.status ('k') | runtime/vm/parser.cc » ('j') | runtime/vm/parser.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698