Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Issue 10882005: Merge 152659 - mac/rlz: Remove an incorrect check (Closed)

Created:
8 years, 4 months ago by Nico
Modified:
8 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Merge 152659 - mac/rlz: Remove an incorrect check As a comment in the ScopedRlzValueStoreLock destructor explains: // Check that "store_ set" => "file_lock acquired". The converse isn't true, // for example if the rlz data file can't be read. So don't CHECK when that happens, instead treat it like lock acquisition failures: Silently drop events when that happens. I added a unit test for this scenario. Also pass O_RDWR to open(), as posix requires one of O_READ, O_WRITE, or O_RDWR. BUG=143950 Review URL: https://chromiumcodereview.appspot.com/10828424 TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152888

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -5 lines) Patch
MM rlz/lib/rlz_lib_test.cc View 2 chunks +19 lines, -0 lines 0 comments Download
MM rlz/lib/rlz_value_store.h View 1 chunk +3 lines, -0 lines 0 comments Download
MM rlz/mac/lib/rlz_value_store_mac.mm View 4 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Nico
8 years, 4 months ago (2012-08-23 00:41:27 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698