Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6586)

Unified Diff: chrome/browser/plugin_finder.h

Issue 10881002: [2] Adding a method to PluginFinder to get a PluginInstaller by WebPluginInfo. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Adding a method to PluginFinder to get a PluginInstaller by WebPluginInfo. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/plugin_finder.cc » ('j') | chrome/browser/plugin_finder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/plugin_finder.h
diff --git a/chrome/browser/plugin_finder.h b/chrome/browser/plugin_finder.h
index f0d75d5c10acbe6612852b7b1fd304e0e8923496..6ac7bab3ba08a6438a0a74bf0d7964f65e348dcf 100644
--- a/chrome/browser/plugin_finder.h
+++ b/chrome/browser/plugin_finder.h
@@ -13,6 +13,7 @@
#include "base/memory/scoped_ptr.h"
#include "base/memory/singleton.h"
#include "base/string16.h"
+#include "webkit/plugins/webplugininfo.h"
namespace base {
class DictionaryValue;
@@ -34,6 +35,9 @@ class PluginFinder {
// Returns the plug-in with the given identifier.
PluginInstaller* FindPluginWithIdentifier(const std::string& identifier);
+ // Gets a plug-in installer using web plug-in info.
+ PluginInstaller* GetPluginInstaller(const webkit::WebPluginInfo& plugin);
+
private:
friend struct DefaultSingletonTraits<PluginFinder>;
friend class Singleton<PluginFinder>;
@@ -52,6 +56,13 @@ class PluginFinder {
PluginInstaller* CreateInstaller(const std::string& identifier,
const base::DictionaryValue* plugin_dict);
+ // Gets the base name of the file path as the identifier.
+ static std::string GetIdentifier(const webkit::WebPluginInfo& plugin);
+
+ // Gets the plug-in group name as the plug-in name if it is not empty or
+ // the filename without extension if the name is empty.
+ static string16 GetGroupName(const webkit::WebPluginInfo& plugin);
+
scoped_ptr<base::DictionaryValue> plugin_list_;
std::map<std::string, PluginInstaller*> installers_;
« no previous file with comments | « no previous file | chrome/browser/plugin_finder.cc » ('j') | chrome/browser/plugin_finder.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698