Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: src/arm/stub-cache-arm.cc

Issue 108803006: Properly restore the receiver after the interceptor call. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1071 matching lines...) Expand 10 before | Expand all | Expand 10 after
1082 } 1082 }
1083 1083
1084 void LoadWithInterceptor(MacroAssembler* masm, 1084 void LoadWithInterceptor(MacroAssembler* masm,
1085 Register receiver, 1085 Register receiver,
1086 Register holder, 1086 Register holder,
1087 Handle<JSObject> holder_obj, 1087 Handle<JSObject> holder_obj,
1088 Register scratch, 1088 Register scratch,
1089 Label* interceptor_succeeded) { 1089 Label* interceptor_succeeded) {
1090 { 1090 {
1091 FrameScope scope(masm, StackFrame::INTERNAL); 1091 FrameScope scope(masm, StackFrame::INTERNAL);
1092 __ Push(holder, name_); 1092 __ Push(receiver, holder, name_);
1093 CompileCallLoadPropertyWithInterceptor( 1093 CompileCallLoadPropertyWithInterceptor(
1094 masm, receiver, holder, name_, holder_obj, 1094 masm, receiver, holder, name_, holder_obj,
1095 IC::kLoadPropertyWithInterceptorOnly); 1095 IC::kLoadPropertyWithInterceptorOnly);
1096 __ pop(name_); // Restore the name. 1096 __ pop(receiver);
1097 __ pop(holder); // Restore the holder. 1097 __ pop(name_);
1098 __ pop(holder);
1098 } 1099 }
1099 // If interceptor returns no-result sentinel, call the constant function. 1100 // If interceptor returns no-result sentinel, call the constant function.
1100 __ LoadRoot(scratch, Heap::kNoInterceptorResultSentinelRootIndex); 1101 __ LoadRoot(scratch, Heap::kNoInterceptorResultSentinelRootIndex);
1101 __ cmp(r0, scratch); 1102 __ cmp(r0, scratch);
1102 __ b(ne, interceptor_succeeded); 1103 __ b(ne, interceptor_succeeded);
1103 } 1104 }
1104 1105
1105 CallStubCompiler* stub_compiler_; 1106 CallStubCompiler* stub_compiler_;
1106 const ParameterCount& arguments_; 1107 const ParameterCount& arguments_;
1107 Register name_; 1108 Register name_;
(...skipping 1780 matching lines...) Expand 10 before | Expand all | Expand 10 after
2888 // ----------------------------------- 2889 // -----------------------------------
2889 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 2890 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
2890 } 2891 }
2891 2892
2892 2893
2893 #undef __ 2894 #undef __
2894 2895
2895 } } // namespace v8::internal 2896 } } // namespace v8::internal
2896 2897
2897 #endif // V8_TARGET_ARCH_ARM 2898 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698