Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4336)

Unified Diff: chrome/browser/android/tab_android.cc

Issue 108803002: Make TabBase non abstract (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/tab_android.h ('k') | chrome/chrome_android.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/tab_android.cc
diff --git a/chrome/browser/android/tab_android.cc b/chrome/browser/android/tab_android.cc
index e317c04d11a9aa1357a4cb6ef3475a95701b920a..a34e6a5d4b0b7d93d3ab7b9a59e474cb9cc49a79 100644
--- a/chrome/browser/android/tab_android.cc
+++ b/chrome/browser/android/tab_android.cc
@@ -229,6 +229,41 @@ void TabAndroid::SetSyncId(int sync_id) {
Java_TabBase_setSyncId(env, obj.obj(), sync_id);
}
+void TabAndroid::HandlePopupNavigation(chrome::NavigateParams* params) {
+ NOTIMPLEMENTED();
+}
+
+void TabAndroid::OnReceivedHttpAuthRequest(jobject auth_handler,
+ const base::string16& host,
+ const base::string16& realm) {
+ NOTIMPLEMENTED();
+}
+
+void TabAndroid::AddShortcutToBookmark(const GURL& url,
+ const base::string16& title,
+ const SkBitmap& skbitmap,
+ int r_value,
+ int g_value,
+ int b_value) {
+ NOTREACHED();
+}
+
+void TabAndroid::EditBookmark(int64 node_id,
+ const base::string16& node_title,
+ bool is_folder,
+ bool is_partner_bookmark) {
+ NOTREACHED();
+}
+
+void TabAndroid::OnNewTabPageReady() {
+ NOTREACHED();
+}
+
+bool TabAndroid::ShouldWelcomePageLinkToTermsOfService() {
+ NOTIMPLEMENTED();
+ return false;
+}
+
void TabAndroid::SwapTabContents(content::WebContents* old_contents,
content::WebContents* new_contents) {
JNIEnv* env = base::android::AttachCurrentThread();
@@ -286,6 +321,10 @@ void TabAndroid::Observe(int type,
}
}
+void TabAndroid::Destroy(JNIEnv* env, jobject obj) {
+ delete this;
+}
+
void TabAndroid::InitWebContents(JNIEnv* env,
jobject obj,
jboolean incognito,
@@ -418,6 +457,12 @@ bool TabAndroid::Print(JNIEnv* env, jobject obj) {
return true;
}
+static void Init(JNIEnv* env, jobject obj) {
+ TRACE_EVENT0("native", "TabAndroid::Init");
+ // This will automatically bind to the Java object and pass ownership there.
+ new TabAndroid(env, obj);
+}
+
bool TabAndroid::RegisterTabAndroid(JNIEnv* env) {
return RegisterNativesImpl(env);
}
« no previous file with comments | « chrome/browser/android/tab_android.h ('k') | chrome/chrome_android.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698