Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2152)

Unified Diff: chrome/android/testshell/java/src/org/chromium/chrome/testshell/TestShellTab.java

Issue 108803002: Make TabBase non abstract (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/testshell/java/src/org/chromium/chrome/testshell/TestShellTab.java
diff --git a/chrome/android/testshell/java/src/org/chromium/chrome/testshell/TestShellTab.java b/chrome/android/testshell/java/src/org/chromium/chrome/testshell/TestShellTab.java
index 7953b7503b079a53684e5562f8597dacb5781c6b..faebeaadb5377a286bcfac72ad8a5a85ff44d9c5 100644
--- a/chrome/android/testshell/java/src/org/chromium/chrome/testshell/TestShellTab.java
+++ b/chrome/android/testshell/java/src/org/chromium/chrome/testshell/TestShellTab.java
@@ -23,8 +23,6 @@ import org.chromium.ui.base.WindowAndroid;
public class TestShellTab extends TabBase {
private long mNativeTestShellTab;
- private CleanupReference mCleanupReference;
-
// Tab state
private boolean mIsLoading;
@@ -45,17 +43,13 @@ public class TestShellTab extends TabBase {
super.initialize();
mNativeTestShellTab = nativeInit();
- mCleanupReference = new CleanupReference(this, new DestroyRunnable(mNativeTestShellTab));
}
@Override
public void destroy() {
super.destroy();
- if (mNativeTestShellTab != 0) {
- mCleanupReference.cleanupNow();
- mNativeTestShellTab = 0;
- }
+ mNativeTestShellTab = 0;
}
/**
@@ -104,17 +98,6 @@ public class TestShellTab extends TabBase {
return new TestShellTabBaseChromeWebContentsDelegateAndroid();
}
- private static final class DestroyRunnable implements Runnable {
- private final long mNativeTestShellTab;
- private DestroyRunnable(long nativeTestShellTab) {
- mNativeTestShellTab = nativeTestShellTab;
- }
- @Override
- public void run() {
- nativeDestroy(mNativeTestShellTab);
- }
- }
-
@Override
protected AutoLoginProcessor createAutoLoginProcessor() {
return new AutoLoginProcessor() {
@@ -151,6 +134,5 @@ public class TestShellTab extends TabBase {
}
private native long nativeInit();
- private static native void nativeDestroy(long nativeTestShellTab);
private native String nativeFixupUrl(long nativeTestShellTab, String url);
}

Powered by Google App Engine
This is Rietveld 408576698