Make TabBase non abstract

chrome/browser/android/tab_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/tab_android.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "chrome/browser/android/chrome_web_contents_delegate_android.h"
 #include "chrome/browser/android/webapps/single_tab_mode_tab_helper.h"
@@ skipping 211 matching lines @@
 }
 
 void TabAndroid::SetSyncId(int sync_id) {
   JNIEnv* env = base::android::AttachCurrentThread();
   ScopedJavaLocalRef<jobject> obj = weak_java_tab_.get(env);
   if (obj.is_null())
     return;
   Java_TabBase_setSyncId(env, obj.obj(), sync_id);
 }
 
+void TabAndroid::HandlePopupNavigation(chrome::NavigateParams* params) {

[Yaron, 2013/12/06 21:25:52]

Can these be NOTREACHED so we don't accidentally hit them in the downstream
impl? I guess that's assuming you can't currently reach these via
testshell/instrumentation tests.

[David Trainor- moved to gerrit, 2013/12/17 19:53:07]

I can do it for the NTP ones, the auth request/popup nav can still be reached
afaik.

+  NOTIMPLEMENTED();
+}
+
+void TabAndroid::OnReceivedHttpAuthRequest(jobject auth_handler,
+                                           const base::string16& host,
+                                           const base::string16& realm) {
+  NOTIMPLEMENTED();
+}
+
+void TabAndroid::AddShortcutToBookmark(const GURL& url,
+                                       const base::string16& title,
+                                       const SkBitmap& skbitmap,
+                                       int r_value,
+                                       int g_value,
+                                       int b_value) {
+  NOTIMPLEMENTED();
+}
+
+void TabAndroid::EditBookmark(int64 node_id,
+                              const base::string16& node_title,
+                              bool is_folder,
+                              bool is_partner_bookmark) {
+  NOTIMPLEMENTED();
+}
+
+void TabAndroid::OnNewTabPageReady() {
+  NOTIMPLEMENTED();
+}
+
+bool TabAndroid::ShouldWelcomePageLinkToTermsOfService() {
+  NOTIMPLEMENTED();
+  return false;
+}
+
 void TabAndroid::SwapTabContents(content::WebContents* old_contents,
                                  content::WebContents* new_contents) {
   JNIEnv* env = base::android::AttachCurrentThread();
 
   // We need to notify the native InfobarContainer so infobars can be swapped.
   InfoBarContainerAndroid* infobar_container =
       reinterpret_cast<InfoBarContainerAndroid*>(
           Java_TabBase_getNativeInfoBarContainer(
               env,
               weak_java_tab_.get(env).obj()));
@@ skipping 37 matching lines @@
     }
     case chrome::NOTIFICATION_FAVICON_UPDATED:
       Java_TabBase_onFaviconUpdated(env, weak_java_tab_.get(env).obj());
       break;
     default:
       NOTREACHED() << "Unexpected notification " << type;
       break;
   }
 }
 
+void TabAndroid::Destroy(JNIEnv* env, jobject obj) {
+  delete this;
+}
+
 void TabAndroid::InitWebContents(JNIEnv* env,
                                  jobject obj,
                                  jboolean incognito,
                                  jobject jcontent_view_core,
                                  jobject jweb_contents_delegate,
                                  jobject jcontext_menu_populator) {
   content::ContentViewCore* content_view_core =
       content::ContentViewCore::GetNativeContentViewCore(env,
                                                          jcontent_view_core);
   DCHECK(content_view_core);
@@ skipping 112 matching lines @@
   printing::PrintViewManagerBasic::CreateForWebContents(web_contents());
   printing::PrintViewManagerBasic* print_view_manager =
       printing::PrintViewManagerBasic::FromWebContents(web_contents());
   if (print_view_manager == NULL)
     return false;
 
   print_view_manager->PrintNow();
   return true;
 }
 
+static void Init(JNIEnv* env, jobject obj) {
+  TRACE_EVENT0("native", "TabAndroid::Init");
+  scoped_ptr<TabAndroid> tab(new TabAndroid(env, obj));
+  // This will automatically bind to the Java object and pass ownership there.
+  ignore_result(tab.release());
+}
+
 bool TabAndroid::RegisterTabAndroid(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }