drive: Fix a crash caused by an empty edit URL

drive: Fix a crash caused by an empty edit URL

For some reason, edit URL can be null in some entries, which
causes a crash.

Along the way, make |callback| parameter of DriveFilesystemInterface::Remove()
mandatory. The only caller in gdata_file_system_proxy.cc passes a non-null
callback.

BUG=144993
TEST=remove operation works as before


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153603

[achuithb, 2012-08-27 21:10:09]

On 2012/08/27 20:25:30, satorux1 wrote:

This is going to cause merge conflicts with
http://codereview.chromium.org/10876075/, but  I guess I'll deal with it.

I fix the same problem with Remove callbacks being non-null.  And I'm removing
some of the functions you modify.

[achuithb, 2012-08-27 21:11:58]

On 2012/08/27 21:10:09, achuith.bhandarkar wrote:
> On 2012/08/27 20:25:30, satorux1 wrote:
> 
> This is going to cause merge conflicts with
> http://codereview.chromium.org/10876075/, but  I guess I'll deal with it.
> 
> I fix the same problem with Remove callbacks being non-null.  And I'm removing
> some of the functions you modify.

Actually I take that back. I think your'e fixing it upstream of what I fixed, so
it's good.

[achuithb, 2012-08-27 21:13:36]

http://codereview.chromium.org/10880075/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/drive_file_system.cc (right):

http://codereview.chromium.org/10880075/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/drive_file_system.cc:1273: GURL(),
What's this?

[satorux1, 2012-08-27 22:07:23]

http://codereview.chromium.org/10880075/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/drive_file_system.cc (right):

http://codereview.chromium.org/10880075/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/drive_file_system.cc:1273: GURL(),
On 2012/08/27 21:13:36, achuith.bhandarkar wrote:
> What's this?

Cannot believe I left this, but this was to test if an empty GURL causes a crash
(and it does). Thank you for catching this. Fixed

[achuithb, 2012-08-27 22:17:11]

lgtm

[commit-bot: I haz the power, 2012-08-27 22:54:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/satorux@chromium.org/10880075/2002

[commit-bot: I haz the power, 2012-08-27 23:03:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/satorux@chromium.org/10880075/12001

[commit-bot: I haz the power, 2012-08-28 01:32:34]

Change committed as 153603