Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: lib/compiler/implementation/compile_time_constants.dart

Issue 10880068: - Change "static final" to "static const" in the lib/ directory. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/colors.dart ('k') | lib/compiler/implementation/compiler.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/compile_time_constants.dart
===================================================================
--- lib/compiler/implementation/compile_time_constants.dart (revision 11400)
+++ lib/compiler/implementation/compile_time_constants.dart (working copy)
@@ -88,7 +88,7 @@
class NullConstant extends PrimitiveConstant {
/** The value a Dart null is compiled to in JavaScript. */
- static final String JsNull = "null";
+ static const String JsNull = "null";
factory NullConstant() => const NullConstant._internal();
const NullConstant._internal();
@@ -353,16 +353,16 @@
* The [PROTO_PROPERTY] must not be used as normal property in any JavaScript
* object. It would change the prototype chain.
*/
- static final String PROTO_PROPERTY = "__proto__";
+ static const String PROTO_PROPERTY = "__proto__";
/** The dart class implementing constant map literals. */
- static final SourceString DART_CLASS = const SourceString("ConstantMap");
- static final SourceString DART_PROTO_CLASS =
+ static const SourceString DART_CLASS = const SourceString("ConstantMap");
+ static const SourceString DART_PROTO_CLASS =
const SourceString("ConstantProtoMap");
- static final SourceString LENGTH_NAME = const SourceString("length");
- static final SourceString JS_OBJECT_NAME = const SourceString("_jsObject");
- static final SourceString KEYS_NAME = const SourceString("_keys");
- static final SourceString PROTO_VALUE = const SourceString("_protoValue");
+ static const SourceString LENGTH_NAME = const SourceString("length");
+ static const SourceString JS_OBJECT_NAME = const SourceString("_jsObject");
+ static const SourceString KEYS_NAME = const SourceString("_keys");
+ static const SourceString PROTO_VALUE = const SourceString("_protoValue");
final ListConstant keys;
final List<Constant> values;
@@ -632,7 +632,7 @@
}
/**
- * Returns a [List] of static final fields that need to be initialized. The
+ * Returns a [List] of static const fields that need to be initialized. The
* list must be evaluated in order since the fields might depend on each
* other.
*/
« no previous file with comments | « lib/compiler/implementation/colors.dart ('k') | lib/compiler/implementation/compiler.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698