Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6589)

Unified Diff: chrome/browser/ui/views/browser_actions_container.h

Issue 10880064: Make extension commands grant the activeTab permission. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/browser_actions_container.h
diff --git a/chrome/browser/ui/views/browser_actions_container.h b/chrome/browser/ui/views/browser_actions_container.h
index 676a50950edd1b3c8da63740740d757059a0c9a8..c6c4b8046a06ba51bf8d9761424223211c43a9f6 100644
--- a/chrome/browser/ui/views/browser_actions_container.h
+++ b/chrome/browser/ui/views/browser_actions_container.h
@@ -5,6 +5,7 @@
#ifndef CHROME_BROWSER_UI_VIEWS_BROWSER_ACTIONS_CONTAINER_H_
#define CHROME_BROWSER_UI_VIEWS_BROWSER_ACTIONS_CONTAINER_H_
+#include "chrome/browser/extensions/extension_keybinding_registry.h"
#include "chrome/browser/extensions/extension_toolbar_model.h"
#include "chrome/browser/ui/views/browser_action_view.h"
#include "chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.h"
@@ -21,6 +22,12 @@
#include "ui/views/widget/widget_observer.h"
class BrowserActionButton;
+class ExtensionKeybindingRegistryViews;
+class ExtensionPopup;
+
+namespace extensions {
+class ActiveTabPermissionGranter;
+}
namespace ui {
class SlideAnimation;
@@ -110,7 +117,8 @@ class BrowserActionsContainer
public ExtensionToolbarModel::Observer,
public BrowserActionOverflowMenuController::Observer,
public views::WidgetObserver,
- public BrowserActionView::Delegate {
+ public BrowserActionView::Delegate,
+ public extensions::ExtensionKeybindingRegistry::Delegate {
public:
BrowserActionsContainer(Browser* browser, views::View* owner_view);
virtual ~BrowserActionsContainer();
@@ -198,6 +206,10 @@ class BrowserActionsContainer
virtual void OnBrowserActionVisibilityChanged() OVERRIDE;
virtual gfx::Point GetViewContentOffset() const OVERRIDE;
+ // Overridden from extension::ExtensionKeybindingRegistry::Delegate:
+ virtual extensions::ActiveTabPermissionGranter*
+ GetActiveTabPermissionGranter() OVERRIDE;
+
// Moves a browser action with |id| to |new_index|.
void MoveBrowserAction(const std::string& extension_id, size_t new_index);
@@ -337,9 +349,6 @@ class BrowserActionsContainer
// own lifetime so that it can stay alive during drag and drop operations.
BrowserActionOverflowMenuController* overflow_menu_;
- // The class that registers for keyboard shortcuts for extension commands.
- ExtensionKeybindingRegistryViews extension_keybinding_registry_;
-
// The animation that happens when the container snaps to place.
scoped_ptr<ui::SlideAnimation> resize_animation_;
@@ -358,6 +367,9 @@ class BrowserActionsContainer
// The x position for where to draw the drop indicator. -1 if no indicator.
int drop_indicator_position_;
+ // The class that registers for keyboard shortcuts for extension commands.
+ scoped_ptr<ExtensionKeybindingRegistryViews> extension_keybinding_registry_;
+
base::WeakPtrFactory<BrowserActionsContainer> task_factory_;
// Handles delayed showing of the overflow menu when hovering.
« no previous file with comments | « chrome/browser/ui/gtk/extensions/shell_window_gtk.cc ('k') | chrome/browser/ui/views/browser_actions_container.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698