Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: chrome/browser/extensions/active_tab_permission_granter.cc

Issue 10880064: Make extension commands grant the activeTab permission. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/active_tab_permission_granter.cc
diff --git a/chrome/browser/extensions/active_tab_permission_manager.cc b/chrome/browser/extensions/active_tab_permission_granter.cc
similarity index 86%
rename from chrome/browser/extensions/active_tab_permission_manager.cc
rename to chrome/browser/extensions/active_tab_permission_granter.cc
index 6b6fd6c43a1833addfdee89ed26517a527663d75..e42fca8f3e4f06a8cbff06fe830a9700a7cbbe9e 100644
--- a/chrome/browser/extensions/active_tab_permission_manager.cc
+++ b/chrome/browser/extensions/active_tab_permission_granter.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/extensions/active_tab_permission_manager.h"
+#include "chrome/browser/extensions/active_tab_permission_granter.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_system.h"
@@ -25,7 +25,7 @@ using content::WebContentsObserver;
namespace extensions {
-ActiveTabPermissionManager::ActiveTabPermissionManager(
+ActiveTabPermissionGranter::ActiveTabPermissionGranter(
content::WebContents* web_contents, int tab_id, Profile* profile)
: WebContentsObserver(web_contents), tab_id_(tab_id) {
registrar_.Add(this,
@@ -33,9 +33,9 @@ ActiveTabPermissionManager::ActiveTabPermissionManager(
content::Source<Profile>(profile));
}
-ActiveTabPermissionManager::~ActiveTabPermissionManager() {}
+ActiveTabPermissionGranter::~ActiveTabPermissionGranter() {}
-void ActiveTabPermissionManager::GrantIfRequested(const Extension* extension) {
+void ActiveTabPermissionGranter::GrantIfRequested(const Extension* extension) {
if (!extension->HasAPIPermission(extensions::APIPermission::kActiveTab))
return;
@@ -64,11 +64,11 @@ void ActiveTabPermissionManager::GrantIfRequested(const Extension* extension) {
new_hosts));
}
-bool ActiveTabPermissionManager::IsGranted(const Extension* extension) {
+bool ActiveTabPermissionGranter::IsGranted(const Extension* extension) {
return granted_extensions_.Contains(extension->id());
}
-void ActiveTabPermissionManager::DidNavigateMainFrame(
+void ActiveTabPermissionGranter::DidNavigateMainFrame(
const content::LoadCommittedDetails& details,
const content::FrameNavigateParams& params) {
if (details.is_in_page)
@@ -77,12 +77,12 @@ void ActiveTabPermissionManager::DidNavigateMainFrame(
ClearActiveExtensionsAndNotify();
}
-void ActiveTabPermissionManager::WebContentsDestroyed(
+void ActiveTabPermissionGranter::WebContentsDestroyed(
content::WebContents* web_contents) {
ClearActiveExtensionsAndNotify();
}
-void ActiveTabPermissionManager::Observe(
+void ActiveTabPermissionGranter::Observe(
int type,
const content::NotificationSource& source,
const content::NotificationDetails& details) {
@@ -94,7 +94,7 @@ void ActiveTabPermissionManager::Observe(
granted_extensions_.Remove(extension->id());
}
-void ActiveTabPermissionManager::ClearActiveExtensionsAndNotify() {
+void ActiveTabPermissionGranter::ClearActiveExtensionsAndNotify() {
if (granted_extensions_.is_empty())
return;
@@ -110,7 +110,7 @@ void ActiveTabPermissionManager::ClearActiveExtensionsAndNotify() {
granted_extensions_.Clear();
}
-int32 ActiveTabPermissionManager::GetPageID() {
+int32 ActiveTabPermissionGranter::GetPageID() {
return web_contents()->GetController().GetActiveEntry()->GetPageID();
}
« no previous file with comments | « chrome/browser/extensions/active_tab_permission_granter.h ('k') | chrome/browser/extensions/active_tab_permission_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698