UMA stats to track drive as default download destination.

UMA stats to track drive as default download destination.

BUG=142051
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156209

[achuithb, 2012-08-26 09:17:48]

Please take a look, Xiyuan!

[xiyuan, 2012-08-27 16:17:28]

lgtm

http://codereview.chromium.org/10880061/diff/3001/chrome/browser/chromeos/pre...
File chrome/browser/chromeos/preferences.cc (right):

http://codereview.chromium.org/10880061/diff/3001/chrome/browser/chromeos/pre...
chrome/browser/chromeos/preferences.cc:312: prefs, this);
nit: same alignment as code around this?

[achuithb, 2012-08-27 21:35:20]

Thanks for the review, Xiyuan!

http://codereview.chromium.org/10880061/diff/3001/chrome/browser/chromeos/pre...
File chrome/browser/chromeos/preferences.cc (right):

http://codereview.chromium.org/10880061/diff/3001/chrome/browser/chromeos/pre...
chrome/browser/chromeos/preferences.cc:312: prefs, this);
On 2012/08/27 16:17:28, xiyuan wrote:
> nit: same alignment as code around this?

Oops, done.

[commit-bot: I haz the power, 2012-09-10 19:06:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/10880061/7001

[commit-bot: I haz the power, 2012-09-10 19:06:51]

Failed to apply patch for chrome/browser/chromeos/preferences.cc:
While running patch -p0 --forward --force;
patching file chrome/browser/chromeos/preferences.cc
Hunk #1 succeeded at 293 (offset -10 lines).
Hunk #2 succeeded at 444 (offset -11 lines).
Hunk #3 FAILED at 619.
1 out of 3 hunks FAILED -- saving rejects to file
chrome/browser/chromeos/preferences.cc.rej

[commit-bot: I haz the power, 2012-09-10 19:10:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/10880061/12001

[commit-bot: I haz the power, 2012-09-10 19:10:45]

Presubmit check for 10880061-12001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/chromeos

Presubmit checks took 3.9s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[achuithb, 2012-09-10 19:12:29]

Satoru-san, need owners lgtm please.

[satorux1, 2012-09-10 21:31:11]

LGTM

[commit-bot: I haz the power, 2012-09-10 22:06:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/10880061/12001

[commit-bot: I haz the power, 2012-09-10 23:19:03]

Try job failure for 10880061-12001 (retry) on linux_chromeos for step
"unit_tests".
It's a second try, previously, step "unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-09-11 22:12:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/10880061/16003

[achuithb, 2012-09-11 22:13:19]

Xiyuan: Could you take a look at preferences_unittest.cc?

[xiyuan, 2012-09-11 22:15:53]

LGTM

[achuithb, 2012-09-11 22:16:29]

On 2012/09/11 22:15:53, xiyuan wrote:
> LGTM

Thank you!

[commit-bot: I haz the power, 2012-09-12 02:07:05]

Change committed as 156209