Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 10880059: Revert 153268 - Refactor manifests to allow all executables to use the same base manifests as Addit… (Closed)

Created:
8 years, 4 months ago by karen
Modified:
8 years, 4 months ago
Reviewers:
gab
CC:
chromium-reviews, grt+watch_chromium.org
Visibility:
Public.

Description

Revert 153268 - Refactor manifests to allow all executables to use the same base manifests as AdditionalManifestFiles Introduce additional.manifest with app compatibility guids and UAC asInvoker property (this is the same as the old chrome.exe.manifest, but without the non-common parts, see chrome.manifest below). Introduce chrome.manifest to keep a property that was set in the previous chrome.(exe|dll).manifest to declare usage of ComCtl32.dll version 6 as is required per http://msdn.microsoft.com/en-us/library/windows/desktop/bb773175(v=vs.85).aspx to get visual styles. BUG=127765 (not really fixing it, but a follow up to the CL for it) TEST=Manifests embedded in chrome.exe, chrome.dll, setup.exe, mini_installer.exe in a VS2010 static build are the exact same as before. Review URL: https://chromiumcodereview.appspot.com/10879020 TBR=gab@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153389

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -48 lines) Patch
D chrome/app/additional.manifest View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/app/chrome.manifest View 1 chunk +0 lines, -8 lines 0 comments Download
A + chrome/app/chrome.exe.manifest View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/chrome_dll.gypi View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/chrome_exe.gypi View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/chrome_installer.gypi View 6 chunks +3 lines, -6 lines 0 comments Download
M chrome/installer/mini_installer.gyp View 2 chunks +5 lines, -8 lines 0 comments Download
M chrome/installer/mini_installer.gypi View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/installer/mini_installer/mini_installer.exe.manifest View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/installer/setup/setup.exe.manifest View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
karen
8 years, 4 months ago (2012-08-25 16:06:22 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698