runtime/vm/gc_marker.cc - Issue 10880019: Disable an expensive GC assert unless heap verification also enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/gc_marker.cc

Issue 10880019: Disable an expensive GC assert unless heap verification also enabled. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/gc_marker.cc

diff --git a/runtime/vm/gc_marker.cc b/runtime/vm/gc_marker.cc

index 8c10e81582cb6e0f81a0027104b86f322c0a41de..6bbec0fcd88d80a846281feafd7d37147b35a57d 100644

--- a/runtime/vm/gc_marker.cc

+++ b/runtime/vm/gc_marker.cc

@@ -164,7 +164,9 @@ class MarkingVisitor : public ObjectPointerVisitor {

private:

void MarkAndPush(RawObject* raw_obj) {

ASSERT(raw_obj->IsHeapObject());

- ASSERT(page_space_->Contains(RawObject::ToAddr(raw_obj)));

+ ASSERT((FLAG_verify_before_gc || FLAG_verify_before_gc) ?

+ page_space_->Contains(RawObject::ToAddr(raw_obj)) :

+ true);

// Mark the object and push it on the marking stack.

ASSERT(!raw_obj->IsMarked());

« no previous file with comments | « no previous file | no next file » | no next file with comments »