Enforces strict manifest content.

Enforces strict manifest content.

This prevents typos and other silly and hard to track errors.
Add new unit test.

R=cmp@chromium.org
NOTRY=true
BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153747

[cmp, 2012-08-28 17:38:29]

https://chromiumcodereview.appspot.com/10880009/diff/4/tools/isolate/run_test...
File tools/isolate/run_test_from_archive.py (right):

https://chromiumcodereview.appspot.com/10880009/diff/4/tools/isolate/run_test...
tools/isolate/run_test_from_archive.py:268: get_assert_is_dict(assert_is_str,
keys)(data)
this code requires a lot of state to be in-mind to verify it's correctness. 
this is possibly ironic, because it is designed to verify the correctness of its
input.  i would prefer that load_manifest be simpler / more straightforward. 
would that make it less fun to write/harder to maintain?

[M-A Ruel, 2012-08-28 20:51:02]

https://chromiumcodereview.appspot.com/10880009/diff/6001/tools/isolate/run_t...
File tools/isolate/run_test_from_archive.py (right):

https://chromiumcodereview.appspot.com/10880009/diff/6001/tools/isolate/run_t...
tools/isolate/run_test_from_archive.py:205: for subsubkey, subsubvalue in
subvalue.iteritems():
The main issue is that it's much easier to make a typo due to the way scoping is
done in python.

But yeah, it's shorter.

[cmp, 2012-08-28 21:06:25]

lgtm, as long as we also keep in mind that new code needs to be easy for people
to parse

[M-A Ruel, 2012-08-28 21:15:04]

On 2012/08/28 21:06:25, cmp wrote:
> lgtm, as long as we also keep in mind that new code needs to be easy for
people
> to parse

Well, that's the question, is this version more readable? I wrote both and I
don't mind smaller functions but I'm official abnormal. At least I don't write
Haskell.

[cmp, 2012-08-28 21:21:20]

Yes!  The new version is much more readable to me than the old version.  Thank
you!

[commit-bot: I haz the power, 2012-08-28 21:31:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/10880009/6001

[commit-bot: I haz the power, 2012-08-28 22:00:58]

Change committed as 153747