content_shell: always initialize logging.

content_shell: always initialize logging.

Previously, logging was only initialized for --dump-render-tree.

BUG=145147
NOTRY=true

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153859

[jln (very slow on Chromium), 2012-08-28 01:36:23]

Hi John,

this should fix logging for content_shell. This could have some side effects,
but I hope it'll be harmless.

In particular, logging::DELETE_OLD_LOG_FILE should ensure that we don't start
creating giant log files.

Let me know if you'd rather have me hide this behind a switch.

[jam, 2012-08-28 02:17:26]

this doesn't appear to match Chrome (see logging_chrome.cc). seems like we want
to match it?

[jln (very slow on Chromium), 2012-08-28 18:22:27]

On 2012/08/28 02:17:26, John Abd-El-Malek wrote:
> this doesn't appear to match Chrome (see logging_chrome.cc). seems like we
want
> to match it?

How much of main Chrome should we match?

I've matched the LoggingDestination (LOG_TO_BOTH_FILE_AND_SYSTEM_DEBUG_LOG /
LOG_ONLY_TO_FILE) and the dcheck_state.

I didn't match logging::APPEND_TO_OLD_LOG_FILE and I've left
logging::DELETE_OLD_LOG_FILE as I fear this could have consequences for build
bots.

Is there a good place where we could move logging_chrome.cc so that both
content_shell and the main Chrome can use it ? I can't think of any.

PTAL!

[jam, 2012-08-28 23:13:14]

patchset1 lgtm, sorry for the confusion

[commit-bot: I haz the power, 2012-08-28 23:18:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jln@chromium.org/10879111/1

[commit-bot: I haz the power, 2012-08-29 01:34:17]

Try job failure for 10879111-1 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-08-29 04:48:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jln@chromium.org/10879111/1

[commit-bot: I haz the power, 2012-08-29 04:50:33]

Change committed as 153859