chrome/renderer/frame_sniffer.cc - Issue 10879105: Moving Chrome code from using WebFrame::name to WebFrame::uniqueName

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/frame_sniffer.cc

Issue 10879105: Moving Chrome code from using WebFrame::name to WebFrame::uniqueName (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/frame_sniffer.cc

diff --git a/chrome/renderer/frame_sniffer.cc b/chrome/renderer/frame_sniffer.cc

index 4546b680c02f95b04f443d7981d007417e33b867..acbe98a8464135c6826e703b5a8608f81c60fdb6 100644

--- a/chrome/renderer/frame_sniffer.cc

+++ b/chrome/renderer/frame_sniffer.cc

@@ -32,5 +32,5 @@ void FrameSniffer::DidCommitProvisionalLoad(WebKit::WebFrame* frame,

}

bool FrameSniffer::ShouldSniffFrame(WebKit::WebFrame* frame) {

- return frame->name() == frame_name_;

+ return frame->uniqueName() == frame_name_;

abarth-chromium 2012/08/27 23:44:38 Should we rename frame_name_ to unique_frame_name_

nasko 2012/08/28 00:02:35 Done.

}

« no previous file with comments | « no previous file | webkit/glue/webkit_glue.cc » ('j') | no next file with comments »