chrome/renderer/frame_sniffer.cc - Issue 10879105: Moving Chrome code from using WebFrame::name to WebFrame::uniqueName

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/renderer/frame_sniffer.cc

Issue 10879105: Moving Chrome code from using WebFrame::name to WebFrame::uniqueName (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | webkit/glue/webkit_glue.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/renderer/frame_sniffer.h"	5 #include "chrome/renderer/frame_sniffer.h"

6	6

7 #include "base/logging.h"	7 #include "base/logging.h"

8 #include "chrome/common/render_messages.h"	8 #include "chrome/common/render_messages.h"

9 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"	9 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"

10 #include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebURLError. h"	10 #include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebURLError. h"

(...skipping 14 matching lines...) Expand all Loading...
25 }	25 }

26	26

27 void FrameSniffer::DidCommitProvisionalLoad(WebKit::WebFrame* frame,	27 void FrameSniffer::DidCommitProvisionalLoad(WebKit::WebFrame* frame,

28 bool is_new_navigation) {	28 bool is_new_navigation) {

29 if (!ShouldSniffFrame(frame))	29 if (!ShouldSniffFrame(frame))

30 return;	30 return;

31 Send(new ChromeViewHostMsg_FrameLoadingCompleted(routing_id()));	31 Send(new ChromeViewHostMsg_FrameLoadingCompleted(routing_id()));

32 }	32 }

33	33

34 bool FrameSniffer::ShouldSniffFrame(WebKit::WebFrame* frame) {	34 bool FrameSniffer::ShouldSniffFrame(WebKit::WebFrame* frame) {

35 return frame->name() == frame_name_;	35 return frame->uniqueName() == frame_name_;
	abarth-chromium 2012/08/27 23:44:38 Should we rename frame_name_ to unique_frame_name_ Should we rename frame_name_ to unique_frame_name_ ? nasko 2012/08/28 00:02:35 Done. Show quoted text On 2012/08/27 23:44:38, abarth wrote: > Should we rename frame_name_ to unique_frame_name_ ? Done.
36 }	36 }

OLD	NEW