Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 10879099: Add linux_asan, mac_asan, linux_chromeos_asan to the list of preferred trybots. (Closed)

Created:
8 years, 3 months ago by Alexander Potapenko
Modified:
8 years, 3 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Add linux_asan, mac_asan, linux_chromeos_asan to the list of preferred trybots. BUG=135155 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154677

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M PRESUBMIT.py View 1 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Alexander Potapenko
PTAL.
8 years, 3 months ago (2012-08-27 17:04:23 UTC) #1
Alexander Potapenko
On 2012/08/27 17:04:23, Alexander Potapenko wrote: > PTAL. In fact browser_tests and content_browsertests shouldn't be ...
8 years, 3 months ago (2012-08-27 17:13:05 UTC) #2
M-A Ruel
https://chromiumcodereview.appspot.com/10879099/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://chromiumcodereview.appspot.com/10879099/diff/1/PRESUBMIT.py#newcode583 PRESUBMIT.py:583: return ['mac_rel', 'mac_asan'] You want all the tests to ...
8 years, 3 months ago (2012-08-27 19:29:24 UTC) #3
Alexander Potapenko
Um, probably yes. All that close the tree should be ran, shouldn't they? I don't ...
8 years, 3 months ago (2012-08-28 12:18:01 UTC) #4
M-A Ruel
On 2012/08/28 12:18:01, Alexander Potapenko wrote: > Um, probably yes. All that close the tree ...
8 years, 3 months ago (2012-08-28 12:21:20 UTC) #5
Alexander Potapenko
On 2012/08/28 12:21:20, Marc-Antoine Ruel wrote: > On 2012/08/28 12:18:01, Alexander Potapenko wrote: > > ...
8 years, 3 months ago (2012-08-28 12:23:35 UTC) #6
Alexander Potapenko
This patch has been landed today.
8 years, 3 months ago (2012-09-03 11:20:40 UTC) #7
nsylvain
On 2012/09/03 11:20:40, Alexander Potapenko wrote: > This patch has been landed today. linux_asan has ...
8 years, 3 months ago (2012-09-04 23:04:59 UTC) #8
nsylvain
On 2012/09/04 23:04:59, nsylvain wrote: > On 2012/09/03 11:20:40, Alexander Potapenko wrote: > > This ...
8 years, 3 months ago (2012-09-04 23:06:12 UTC) #9
Alexander Potapenko
8 years, 3 months ago (2012-09-05 11:02:47 UTC) #10
Ok, I can disable the linux_asan bot for now. I'll also try to make the test
list shorter.
WDYT we should do in the long term? Can we add more bots to the pool?

Powered by Google App Engine
This is Rietveld 408576698