Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: src/trusted/validator_arm/gen/arm32_decode.cc

Issue 10879090: ARM validator: continue with extra_load_store_instructions. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Update with more tables. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/validator_arm/gen/arm32_decode.cc
diff --git a/src/trusted/validator_arm/gen/arm32_decode.cc b/src/trusted/validator_arm/gen/arm32_decode.cc
index f99406d862b673468dabd646ed2977e9b2501d56..4b87a4146f017afc4133a3f374ac2926c9ab82f3 100644
--- a/src/trusted/validator_arm/gen/arm32_decode.cc
+++ b/src/trusted/validator_arm/gen/arm32_decode.cc
@@ -946,38 +946,48 @@ const ClassDecoder& Arm32DecoderState::decode_miscellaneous_instructions(
const Instruction insn) const
{
if ((insn.Bits() & 0x00000070) == 0x00000000 /* op2(6:4) == 000 */ &&
+ (insn.Bits() & 0x00000200) == 0x00000000 /* B(9:9) == 0 */ &&
(insn.Bits() & 0x00600000) == 0x00200000 /* op(22:21) == 01 */ &&
(insn.Bits() & 0x00030000) == 0x00000000 /* op1(19:16) == xx00 */ &&
- (insn.Bits() & 0x0000FF00) == 0x0000F000 /* $pattern(31:0) == xxxxxxxxxxxxxxxx11110000xxxxxxxx */) {
+ (insn.Bits() & 0x0000FD00) == 0x0000F000 /* $pattern(31:0) == xxxxxxxxxxxxxxxx111100x0xxxxxxxx */) {
return Unary1RegisterUse_instance_;
}
if ((insn.Bits() & 0x00000070) == 0x00000000 /* op2(6:4) == 000 */ &&
+ (insn.Bits() & 0x00000200) == 0x00000000 /* B(9:9) == 0 */ &&
(insn.Bits() & 0x00600000) == 0x00200000 /* op(22:21) == 01 */ &&
(insn.Bits() & 0x00030000) == 0x00010000 /* op1(19:16) == xx01 */ &&
- (insn.Bits() & 0x0000FF00) == 0x0000F000 /* $pattern(31:0) == xxxxxxxxxxxxxxxx11110000xxxxxxxx */) {
+ (insn.Bits() & 0x0000FD00) == 0x0000F000 /* $pattern(31:0) == xxxxxxxxxxxxxxxx111100x0xxxxxxxx */) {
return Forbidden_instance_;
}
if ((insn.Bits() & 0x00000070) == 0x00000000 /* op2(6:4) == 000 */ &&
+ (insn.Bits() & 0x00000200) == 0x00000000 /* B(9:9) == 0 */ &&
(insn.Bits() & 0x00600000) == 0x00200000 /* op(22:21) == 01 */ &&
(insn.Bits() & 0x00020000) == 0x00020000 /* op1(19:16) == xx1x */ &&
- (insn.Bits() & 0x0000FF00) == 0x0000F000 /* $pattern(31:0) == xxxxxxxxxxxxxxxx11110000xxxxxxxx */) {
+ (insn.Bits() & 0x0000FD00) == 0x0000F000 /* $pattern(31:0) == xxxxxxxxxxxxxxxx111100x0xxxxxxxx */) {
return Forbidden_instance_;
}
if ((insn.Bits() & 0x00000070) == 0x00000000 /* op2(6:4) == 000 */ &&
+ (insn.Bits() & 0x00000200) == 0x00000000 /* B(9:9) == 0 */ &&
(insn.Bits() & 0x00600000) == 0x00600000 /* op(22:21) == 11 */ &&
- (insn.Bits() & 0x0000FF00) == 0x0000F000 /* $pattern(31:0) == xxxxxxxxxxxxxxxx11110000xxxxxxxx */) {
+ (insn.Bits() & 0x0000FD00) == 0x0000F000 /* $pattern(31:0) == xxxxxxxxxxxxxxxx111100x0xxxxxxxx */) {
return Forbidden_instance_;
}
if ((insn.Bits() & 0x00000070) == 0x00000000 /* op2(6:4) == 000 */ &&
+ (insn.Bits() & 0x00000200) == 0x00000000 /* B(9:9) == 0 */ &&
(insn.Bits() & 0x00200000) == 0x00000000 /* op(22:21) == x0 */ &&
- (insn.Bits() & 0x000F0F0F) == 0x000F0000 /* $pattern(31:0) == xxxxxxxxxxxx1111xxxx0000xxxx0000 */) {
+ (insn.Bits() & 0x000F0D0F) == 0x000F0000 /* $pattern(31:0) == xxxxxxxxxxxx1111xxxx00x0xxxx0000 */) {
return Unary1RegisterSet_instance_;
}
+ if ((insn.Bits() & 0x00000070) == 0x00000000 /* op2(6:4) == 000 */ &&
+ (insn.Bits() & 0x00000200) == 0x00000200 /* B(9:9) == 1 */) {
+ return Forbidden_instance_;
+ }
+
if ((insn.Bits() & 0x00000070) == 0x00000010 /* op2(6:4) == 001 */ &&
(insn.Bits() & 0x00600000) == 0x00200000 /* op(22:21) == 01 */ &&
(insn.Bits() & 0x000FFF00) == 0x000FFF00 /* $pattern(31:0) == xxxxxxxxxxxx111111111111xxxxxxxx */) {
@@ -1006,12 +1016,22 @@ const ClassDecoder& Arm32DecoderState::decode_miscellaneous_instructions(
return decode_saturating_addition_and_subtraction(insn);
}
+ if ((insn.Bits() & 0x00000070) == 0x00000060 /* op2(6:4) == 110 */ &&
+ (insn.Bits() & 0x00600000) == 0x00600000 /* op(22:21) == 11 */) {
+ return Forbidden_instance_;
+ }
+
if ((insn.Bits() & 0x00000070) == 0x00000070 /* op2(6:4) == 111 */ &&
(insn.Bits() & 0x00600000) == 0x00200000 /* op(22:21) == 01 */) {
return Breakpoint_instance_;
}
if ((insn.Bits() & 0x00000070) == 0x00000070 /* op2(6:4) == 111 */ &&
+ (insn.Bits() & 0x00600000) == 0x00400000 /* op(22:21) == 10 */) {
+ return Forbidden_instance_;
+ }
+
+ if ((insn.Bits() & 0x00000070) == 0x00000070 /* op2(6:4) == 111 */ &&
(insn.Bits() & 0x00600000) == 0x00600000 /* op(22:21) == 11 */ &&
(insn.Bits() & 0x000FFF00) == 0x00000000 /* $pattern(31:0) == xxxxxxxxxxxx000000000000xxxxxxxx */) {
return Forbidden_instance_;
@@ -1067,12 +1087,14 @@ const ClassDecoder& Arm32DecoderState::decode_msr_immediate_and_hints(
}
if ((insn.Bits() & 0x00400000) == 0x00000000 /* op(22:22) == 0 */ &&
- (insn.Bits() & 0x000F0000) == 0x00040000 /* op1(19:16) == 0100 */) {
+ (insn.Bits() & 0x000F0000) == 0x00040000 /* op1(19:16) == 0100 */ &&
+ (insn.Bits() & 0x0000F000) == 0x0000F000 /* $pattern(31:0) == xxxxxxxxxxxxxxxx1111xxxxxxxxxxxx */) {
return DontCareInst_instance_;
}
if ((insn.Bits() & 0x00400000) == 0x00000000 /* op(22:22) == 0 */ &&
- (insn.Bits() & 0x000B0000) == 0x00080000 /* op1(19:16) == 1x00 */) {
+ (insn.Bits() & 0x000B0000) == 0x00080000 /* op1(19:16) == 1x00 */ &&
+ (insn.Bits() & 0x0000F000) == 0x0000F000 /* $pattern(31:0) == xxxxxxxxxxxxxxxx1111xxxxxxxxxxxx */) {
return DontCareInst_instance_;
}

Powered by Google App Engine
This is Rietveld 408576698