Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: chrome/browser/extensions/api/push_messaging/push_messaging_api.cc

Issue 10879082: Change the separator for chhanel id to a / for consistency. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/push_messaging/push_messaging_api.cc
===================================================================
--- chrome/browser/extensions/api/push_messaging/push_messaging_api.cc (revision 153336)
+++ chrome/browser/extensions/api/push_messaging/push_messaging_api.cc (working copy)
@@ -34,6 +34,10 @@
using content::BrowserThread;
+namespace {
+static const char kChannelIdSeparator[] = "/";
+}
+
namespace extensions {
namespace glue = api::experimental_push_messaging;
@@ -165,7 +169,7 @@
// channel ID here.
std::string channel_id(gaia_id);
if (!gaia_id.empty()) {
- channel_id += ".";
+ channel_id += kChannelIdSeparator;
channel_id += extension_id();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698