Issue 10879082: Change the separator for chhanel id to a / for consistency. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(912)

My Issues | Starred Open | Closed | All

Issue 10879082: Change the separator for chhanel id to a / for consistency. (Closed)

Created:
8 years, 4 months ago by Munjal (Google)

Modified:
8 years, 3 months ago

Reviewers:
Mihai Parparita -not on Chrome, Pete Williamson, dcheng

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Change the separator for channel ID to a / for consistency. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153400

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	chrome/browser/extensions/api/push_messaging/push_messaging_api.cc	View		2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Munjal (Google)

Mihai for owners. Daniel, Pete is not a reviewer yet. Can you take a look?

8 years, 4 months ago (2012-08-24 23:20:51 UTC) #2

dcheng

On 2012/08/24 23:22:37, dcheng wrote: > lgtm Btw, we should add an extension test for ...

8 years, 4 months ago (2012-08-24 23:22:51 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/munjal@chromium.org/10879082/1

8 years, 4 months ago (2012-08-25 00:12:34 UTC) #6

Change committed as 153400

Expand Messages | Collapse Messages

Powered by Google App Engine

This is Rietveld 408576698