Shard DatabaseTracker

content/browser/browser_context.cc

Index: content/browser/browser_context.cc
===================================================================
--- content/browser/browser_context.cc	(revision 152808)
+++ content/browser/browser_context.cc	(working copy)
@@ -106,13 +106,6 @@
   return GetDefaultStoragePartition(browser_context)->GetIndexedDBContext();
 }
 
-webkit_database::DatabaseTracker* BrowserContext::GetDatabaseTracker(
-    BrowserContext* browser_context) {
-  // TODO(ajwong): Change this API to require a SiteInstance instead of
-  // using GetDefaultStoragePartition().
-  return GetDefaultStoragePartition(browser_context)->GetDatabaseTracker();
-}
-
 appcache::AppCacheService* BrowserContext::GetAppCacheService(
     BrowserContext* browser_context) {
   // TODO(ajwong): Change this API to require a SiteInstance instead of
@@ -173,7 +166,8 @@
 }
 
 void BrowserContext::SaveSessionState(BrowserContext* browser_context) {
-  GetDatabaseTracker(browser_context)->SetForceKeepSessionState();
+  GetDefaultStoragePartition(browser_context)->GetDatabaseTracker()->

[awong, 2012/08/27 21:11:25]

Should this use the ForEachStoragePartiion and call SetForceKeepSessionState()
over everything?
If the ordering isn't too critical, we could also do the same thing on
DOMStorageContextImpl.

BTW, is this method safe to call on the UI thread?

[michaeln, 2012/08/27 22:09:57]

For now, i've been avoiding putting behaviors related to general settings on top
of isolated partitions, for at least a few reasons...

* Not clear what the desired relationship between general settings and isolated
app settings is?

* Calling ForEachPartition doesn't really cut it since unless the partition has
been accessed, there won't be an instance in memory to poke at.

* FUD
thread-safe, yes

+      SetForceKeepSessionState();
 
   if (BrowserThread::IsMessageLoopValid(BrowserThread::IO)) {
     BrowserThread::PostTask(