Shard DatabaseTracker

content/browser/browser_context.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/browser/browser_context.h"
 
 #include "content/browser/appcache/chrome_appcache_service.h"
 #include "webkit/database/database_tracker.h"
 #include "content/browser/dom_storage/dom_storage_context_impl.h"
 #include "content/browser/download/download_file_manager.h"
@@ skipping 88 matching lines @@
       context, kDownloadManagerKeyName);
 }
 
 IndexedDBContext* BrowserContext::GetIndexedDBContext(
     BrowserContext* browser_context) {
   // TODO(ajwong): Change this API to require a SiteInstance instead of
   // using GetDefaultStoragePartition().
   return GetDefaultStoragePartition(browser_context)->GetIndexedDBContext();
 }
 
-webkit_database::DatabaseTracker* BrowserContext::GetDatabaseTracker(
-    BrowserContext* browser_context) {
-  // TODO(ajwong): Change this API to require a SiteInstance instead of
-  // using GetDefaultStoragePartition().
-  return GetDefaultStoragePartition(browser_context)->GetDatabaseTracker();
-}
-
 appcache::AppCacheService* BrowserContext::GetAppCacheService(
     BrowserContext* browser_context) {
   // TODO(ajwong): Change this API to require a SiteInstance instead of
   // using GetDefaultStoragePartition().
   return GetDefaultStoragePartition(browser_context)->GetAppCacheService();
 }
 
 fileapi::FileSystemContext* BrowserContext::GetFileSystemContext(
     BrowserContext* browser_context) {
   // TODO(ajwong): Change this API to require a SiteInstance instead of
@@ skipping 40 matching lines @@
   // ResourceContext::InitializeResourceContext() directly here is that
   // ResourceContext initialization may call back into BrowserContext
   // and when that call returns it'll end rewriting its UserData map. It will
   // end up rewriting the same value but this still causes a race condition.
   //
   // See http://crbug.com/115678.
   GetDefaultStoragePartition(context);
 }
 
 void BrowserContext::SaveSessionState(BrowserContext* browser_context) {
-  GetDatabaseTracker(browser_context)->SetForceKeepSessionState();
+  GetDefaultStoragePartition(browser_context)->GetDatabaseTracker()->

[awong, 2012/08/27 21:11:25]

Should this use the ForEachStoragePartiion and call SetForceKeepSessionState()
over everything?
If the ordering isn't too critical, we could also do the same thing on
DOMStorageContextImpl.

BTW, is this method safe to call on the UI thread?

[michaeln, 2012/08/27 22:09:57]

For now, i've been avoiding putting behaviors related to general settings on top
of isolated partitions, for at least a few reasons...

* Not clear what the desired relationship between general settings and isolated
app settings is?

* Calling ForEachPartition doesn't really cut it since unless the partition has
been accessed, there won't be an instance in memory to poke at.

* FUD
thread-safe, yes

+      SetForceKeepSessionState();
 
   if (BrowserThread::IsMessageLoopValid(BrowserThread::IO)) {
     BrowserThread::PostTask(
         BrowserThread::IO, FROM_HERE,
         base::Bind(&SaveSessionStateOnIOThread,
                    browser_context->GetResourceContext()));
   }
 
   DOMStorageContextImpl* dom_storage_context_impl =
       static_cast<DOMStorageContextImpl*>(
@@ skipping 21 matching lines @@
   ForEachStoragePartition(browser_context,
                           base::Bind(&PurgeDOMStorageContextInPartition));
 }
 
 BrowserContext::~BrowserContext() {
   if (GetUserData(kDownloadManagerKeyName))
     GetDownloadManager(this)->Shutdown();
 }
 
 }  // namespace content