Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Issue 10879063: Don't re-create ShellDownloadManagerDelegate if it already exists. (Closed)

Created:
8 years, 4 months ago by Randy Smith (Not in Mondays)
Modified:
8 years, 3 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Don't re-create ShellDownloadManagerDelegate if it already exists. BUG=None R=jam@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153522

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M content/shell/shell_browser_context.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Randy Smith (Not in Mondays)
John: Any reason this isn't obviously the right thing to do?
8 years, 4 months ago (2012-08-24 14:27:01 UTC) #1
jam
lgtm
8 years, 3 months ago (2012-08-27 17:22:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdsmith@chromium.org/10879063/1
8 years, 3 months ago (2012-08-27 17:23:55 UTC) #3
commit-bot: I haz the power
8 years, 3 months ago (2012-08-27 19:43:01 UTC) #4
Change committed as 153522

Powered by Google App Engine
This is Rietveld 408576698