Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 10879057: Revert changes from r152523 and split bitstream converter creation and enabling. (Closed)

Created:
8 years, 4 months ago by acolwell GONE FROM CHROMIUM
Modified:
8 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Revert changes from r152523 and split bitstream converter creation and enabling. Bitstream converter now gets created when we know the FFmpeg structs are valid. Enabling the converter no longer needs access to these structs so the crash is avoided. BUG=144432 TEST=Manual testing with GPU video decoder init failing and falling back to software decode. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153204

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -19 lines) Patch
M media/filters/ffmpeg_demuxer.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 4 chunks +10 lines, -8 lines 0 comments Download
M media/filters/gpu_video_decoder.cc View 3 chunks +4 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
acolwell GONE FROM CHROMIUM
This may look familiar. ;) I've verified this works properly when GPU video initialization fails. ...
8 years, 4 months ago (2012-08-24 01:11:40 UTC) #1
Ami GONE FROM CHROMIUM
LGTM we should do all our coding & reviewing this way!
8 years, 4 months ago (2012-08-24 02:52:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/10879057/1
8 years, 4 months ago (2012-08-24 06:06:24 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-24 09:35:56 UTC) #4
Try job failure for 10879057-1 (retry) on linux_chromeos for step
"browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

Powered by Google App Engine
This is Rietveld 408576698