Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1026)

Unified Diff: chrome/browser/autocomplete/history_provider_util.h

Issue 10879042: Move IsHostOnly() from HistoryURL provider to HistoryMatch (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/autocomplete/history_provider_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autocomplete/history_provider_util.h
diff --git a/chrome/browser/autocomplete/history_provider_util.h b/chrome/browser/autocomplete/history_provider_util.h
index b30ce1f34d767bad119f762a62a9cdd32631839d..05ebea2e081a83c7de760de90e414df66d869276 100644
--- a/chrome/browser/autocomplete/history_provider_util.h
+++ b/chrome/browser/autocomplete/history_provider_util.h
@@ -24,6 +24,14 @@ struct HistoryMatch {
static bool EqualsGURL(const HistoryMatch& h, const GURL& url);
+ // Returns true if url in this HistoryMatch is just a host
+ // (e.g. "http://www.google.com/") and not some other subpage
+ // (e.g. "http://www.google.com/foo.html"). This could rightly go
+ // in gurl.h itself but no one else does this in production code (so
+ // I'm not bloating gurl.h with an apparently not-generally-needed
mrossetti 2012/08/23 17:18:36 Nit: No need to explain about why this doesn't go
Mark P 2012/08/23 17:20:56 Done.
+ // function).
+ bool IsHostOnly() const;
+
URLRow url_info;
// The offset of the user's input within the URL.
« no previous file with comments | « no previous file | chrome/browser/autocomplete/history_provider_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698