Move IsHostOnly() from HistoryURL provider to HistoryMatch

Move IsHostOnly() from HistoryURL provider to HistoryMatch

HistoryMatch is used by both URLs from history providers.  I will soon need this function in the HistoryQuickProvider.

For reference: I searched users of GURL who do something similar.  I found a handful, but all these uses are either in test or DCHECKs (like this one).  (The most common equivalent use is
DCHECK(url == url.GetWithEmptyPath());
.)  Given that no one else seems to use this kind of logic in production Chrome, I didn't think I should clutter the GURL interface with a function that doesn't add much value.  Hence I'm leaving it the autocomplete part of the code for now.

BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153421

[Mark P, 2012-08-23 17:09:27]

Once you okay it, I'll get Peter to approve it too.

--mark

[mrossetti, 2012-08-23 17:18:36]

LGTM

https://chromiumcodereview.appspot.com/10879042/diff/1/chrome/browser/autocom...
File chrome/browser/autocomplete/history_provider_util.h (right):

https://chromiumcodereview.appspot.com/10879042/diff/1/chrome/browser/autocom...
chrome/browser/autocomplete/history_provider_util.h:31: // I'm not bloating
gurl.h with an apparently not-generally-needed
Nit: No need to explain about why this doesn't go into gurl.h.

[Mark P, 2012-08-23 17:20:56]

https://chromiumcodereview.appspot.com/10879042/diff/1/chrome/browser/autocom...
File chrome/browser/autocomplete/history_provider_util.h (right):

https://chromiumcodereview.appspot.com/10879042/diff/1/chrome/browser/autocom...
chrome/browser/autocomplete/history_provider_util.h:31: // I'm not bloating
gurl.h with an apparently not-generally-needed
On 2012/08/23 17:18:36, mrossetti wrote:
> Nit: No need to explain about why this doesn't go into gurl.h.

Done.

[Mark P, 2012-08-23 17:21:53]

Peter,

This should be easy to review.

--mark

[Peter Kasting, 2012-08-25 04:38:57]

LGTM

https://chromiumcodereview.appspot.com/10879042/diff/3001/chrome/browser/auto...
File chrome/browser/autocomplete/history_provider_util.cc (right):

https://chromiumcodereview.appspot.com/10879042/diff/3001/chrome/browser/auto...
chrome/browser/autocomplete/history_provider_util.cc:6: #include
"base/logging.h"
Nit: Alphabetical

[Mark P, 2012-08-26 01:23:04]

https://chromiumcodereview.appspot.com/10879042/diff/3001/chrome/browser/auto...
File chrome/browser/autocomplete/history_provider_util.cc (right):

https://chromiumcodereview.appspot.com/10879042/diff/3001/chrome/browser/auto...
chrome/browser/autocomplete/history_provider_util.cc:6: #include
"base/logging.h"
On 2012/08/25 04:38:57, Peter Kasting wrote:
> Nit: Alphabetical

I thought the associated .h file always came first.

Added a vertical space between these two to make the "our header first" more
obvious.

[Peter Kasting, 2012-08-26 03:27:12]

Yeah, you're right.  The vertical space helps a lot, I wouldn't have thought
about that otherwise.

[commit-bot: I haz the power, 2012-08-26 16:17:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/10879042/3003

[commit-bot: I haz the power, 2012-08-26 18:35:13]

Change committed as 153421