Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1228)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10879037: Rename InfoBarTabService -> InfoBarService. (Closed)

Created:
8 years, 3 months ago by Jói
Modified:
8 years, 3 months ago
CC:
chromium-reviews, Avi (use Gerrit), mihaip-chromium-reviews_chromium.org, creis+watch_chromium.org, dyu1, tfarina, dhollowa+watch_chromium.org, ajwong+watch_chromium.org, browser-components-watch_chromium.org, jam, Aaron Boodman, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, brettw-cc_chromium.org, stuartmorgan+watch_chromium.org, Ilya Sherman
Visibility:
Public.

Description

Rename InfoBarTabService -> InfoBarService. This addresses a TODO where I noticed that the InfoBArService API has no notion of a tab and in some implementations might not be tied to a tab. TBR=trivialusageupdates@chromium.org BUG=140037 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154023

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : Fix include guard #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -183 lines) Patch
M chrome/browser/api/infobars/confirm_infobar_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/api/infobars/confirm_infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/api/infobars/infobar_delegate.h View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/api/infobars/infobar_delegate.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/api/infobars/infobar_service.h View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
D chrome/browser/api/infobars/infobar_tab_service.h View 1 chunk +0 lines, -63 lines 0 comments Download
M chrome/browser/api/infobars/link_infobar_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/api/infobars/link_infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/api/infobars/simple_alert_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/api/infobars/simple_alert_infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/api/autofill_manager_delegate.h View 2 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/autofill/autofill_browsertest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/autofill/autofill_cc_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_cc_infobar_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autofill/autofill_feedback_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_feedback_infobar_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autofill/autofill_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autofill/autofill_metrics_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/custom_handlers/register_protocol_handler_infobar_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/custom_handlers/register_protocol_handler_infobar_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_request_infobar_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_request_infobar_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_infobar_delegate.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_infobar_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/infobars/infobar_tab_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/infobars/infobar_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugin_infobar_delegates.h View 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/plugin_infobar_delegates.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/translate/translate_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/infobar_stubs.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/before_translate_infobar_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/infobars/extension_infobar_controller.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_controller.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_controller.mm View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/media_stream_infobar_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/media_stream_infobar_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/keystone_infobar_delegate.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/infobars/confirm_infobar_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/infobars/extension_infobar_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/infobars/link_infobar_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/infobars/media_stream_infobar_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/infobars/translate_infobar_base_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/media_stream_infobar_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_autofill_manager_delegate.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tab_contents/tab_autofill_manager_delegate.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/confirm_infobar.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/extension_infobar.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/link_infobar.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/media_stream_infobar.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/translate_infobar_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Jói
8 years, 3 months ago (2012-08-23 12:35:14 UTC) #1
erikwright (departed)
LGTM. http://codereview.chromium.org/10879037/diff/1053/chrome/browser/api/infobars/infobar_service.h File chrome/browser/api/infobars/infobar_service.h (right): http://codereview.chromium.org/10879037/diff/1053/chrome/browser/api/infobars/infobar_service.h#newcode5 chrome/browser/api/infobars/infobar_service.h:5: #ifndef CHROME_BROWSER_API_INFOBARS_INFOBAR_TAB_SERVICE_H_ fix header guards
8 years, 3 months ago (2012-08-23 16:17:38 UTC) #2
Jói
8 years, 3 months ago (2012-08-23 16:36:52 UTC) #3 
Thanks for the catch.

On Thu, Aug 23, 2012 at 4:17 PM,  <erikwright@chromium.org> wrote:
> LGTM.
>
>
>
http://codereview.chromium.org/10879037/diff/1053/chrome/browser/api/infobars...
> File chrome/browser/api/infobars/infobar_service.h (right):
>
>
http://codereview.chromium.org/10879037/diff/1053/chrome/browser/api/infobars...
> chrome/browser/api/infobars/infobar_service.h:5: #ifndef
> CHROME_BROWSER_API_INFOBARS_INFOBAR_TAB_SERVICE_H_
> fix header guards
>
> http://codereview.chromium.org/10879037/

Powered by Google App Engine
This is Rietveld 408576698