Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: runtime/vm/flow_graph_allocator.cc

Issue 10879036: Compute the def-use list on-demand by walking the dominator tree. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Unneeded include. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_allocator.cc
diff --git a/runtime/vm/flow_graph_allocator.cc b/runtime/vm/flow_graph_allocator.cc
index dc10bb7888124bd449bec47d9670d97599f9d0e9..a9285f73a5262f687b20434e25f854766ccd519e 100644
--- a/runtime/vm/flow_graph_allocator.cc
+++ b/runtime/vm/flow_graph_allocator.cc
@@ -102,10 +102,7 @@ void FlowGraphAllocator::EliminateEnvironmentUses() {
PushArgumentInstr* push_argument = def->AsPushArgument();
if ((push_argument != NULL) && push_argument->WasEliminated()) {
- // TODO(zerny): This should be unreachable if we could properly
- // replace uses by values. (See RemovePushArguments in
- // flow_graph_optimizer.cc).
- (*values)[i] = push_argument->value();
+ (*values)[i] = push_argument->value()->CopyValue();
continue;
}

Powered by Google App Engine
This is Rietveld 408576698