Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Unified Diff: runtime/vm/intermediate_language_test.cc

Issue 10879036: Compute the def-use list on-demand by walking the dominator tree. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/flow_graph.cc ('K') | « runtime/vm/intermediate_language.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_test.cc
diff --git a/runtime/vm/intermediate_language_test.cc b/runtime/vm/intermediate_language_test.cc
index bea3873a395831aa1d61702872690826d9269387..cd7db514a9002ef5eca05e73bd94dcb2d7e6a793 100644
--- a/runtime/vm/intermediate_language_test.cc
+++ b/runtime/vm/intermediate_language_test.cc
@@ -2,6 +2,7 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
+#include "vm/flow_graph.h"
#include "vm/intermediate_language.h"
#include "vm/unit_test.h"
@@ -17,36 +18,6 @@ TEST_CASE(InstructionTests) {
EXPECT(!bind_instr->IsBlockEntry());
}
-TEST_CASE(DefUseTests) {
- Definition* def1 = new PhiInstr(0);
- Definition* def2 = new PhiInstr(0);
- EXPECT(def1->use_list() == NULL);
- EXPECT(def2->use_list() == NULL);
- UseVal* use1 = new UseVal(def1);
- EXPECT(def1->use_list() == use1);
- EXPECT(def1->use_list()->next_use() == NULL);
- UseVal* use2 = new UseVal(def1);
- EXPECT(def1->use_list()->next_use()->next_use() == NULL);
- UseVal* use3 = new UseVal(def1);
- EXPECT(def1->use_list()->next_use()->next_use()->next_use() == NULL);
- use1->RemoveFromUseList();
- EXPECT(def1->use_list()->next_use()->next_use() == NULL);
- use3->SetDefinition(def2);
- EXPECT(def1->use_list() == use2);
- EXPECT(def1->use_list()->next_use() == NULL);
- EXPECT(def2->use_list() == use3);
- EXPECT(def2->use_list()->next_use() == NULL);
- BindInstr* bind =
- new BindInstr(BindInstr::kUsed, new BooleanNegateComp(use2));
- bind->RemoveInputUses();
- EXPECT(def1->use_list() == NULL);
- // Test replacing with a definition without uses.
- UseVal* use4 = new UseVal(def2);
- def2->ReplaceUsesWith(def1);
- EXPECT(def1->use_list() == use4);
- EXPECT(def2->use_list() == NULL);
- EXPECT(use4->definition() == def1);
-}
TEST_CASE(OptimizationTests) {
Definition* def1 = new PhiInstr(0);
« runtime/vm/flow_graph.cc ('K') | « runtime/vm/intermediate_language.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698