Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: runtime/vm/compiler.cc

Issue 10879036: Compute the def-use list on-demand by walking the dominator tree. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph.h » ('j') | runtime/vm/flow_graph.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/compiler.cc
diff --git a/runtime/vm/compiler.cc b/runtime/vm/compiler.cc
index ed72ea0cac11468664297c04ba2c2529bfe72bd8..20a816c8564372e880e453a8a2d3284650ff9f00 100644
--- a/runtime/vm/compiler.cc
+++ b/runtime/vm/compiler.cc
@@ -165,6 +165,7 @@ static bool CompileParsedFunctionHelper(const ParsedFunction& parsed_function,
// Transform to SSA.
if (optimized) {
flow_graph->ComputeSSA();
+ flow_graph->ComputeUseLists();
}
if (FLAG_print_flow_graph) {
@@ -181,22 +182,27 @@ static bool CompileParsedFunctionHelper(const ParsedFunction& parsed_function,
if (optimized) {
FlowGraphOptimizer optimizer(*flow_graph);
optimizer.ApplyICData();
+ ASSERT(flow_graph->ComputeUseLists());
Vyacheslav Egorov (Google) 2012/08/23 13:51:10 ASSERT is compiled out in Release mode so this wil
// Propagate types and eliminate more type tests.
FlowGraphTypePropagator propagator(*flow_graph);
propagator.PropagateTypes();
+ ASSERT(flow_graph->ComputeUseLists());
// Do optimizations that depend on the propagated type information.
optimizer.OptimizeComputations();
+ ASSERT(flow_graph->ComputeUseLists());
if (FLAG_local_cse) {
LocalCSE local_cse(*flow_graph);
local_cse.Optimize();
+ ASSERT(flow_graph->ComputeUseLists());
}
// Perform register allocation on the SSA graph.
FlowGraphAllocator allocator(*flow_graph);
allocator.AllocateRegisters();
+ ASSERT(flow_graph->ComputeUseLists());
if (FLAG_print_flow_graph) {
OS::Print("After Optimizations:\n");
« no previous file with comments | « no previous file | runtime/vm/flow_graph.h » ('j') | runtime/vm/flow_graph.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698