Add VKEY_POWER to the POSIX KeyboardCode enum.

Add VKEY_POWER to the POSIX KeyboardCode enum.

I'm mapping XF86XK_PowerOff to VKEY_POWER on X.  Otherwise,
power button events on Chrome OS are mapped to VKEY_UNKNOWN
and get thrown on the floor before we can interpret them as
user activity.

BUG=chromium:144295
TEST=power button undims the screen on chrome os


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152921

[Daniel Erat, 2012-08-22 22:20:47]

https://chromiumcodereview.appspot.com/10879023/diff/1/ui/base/keycodes/keybo...
File ui/base/keycodes/keyboard_codes_posix.h (right):

https://chromiumcodereview.appspot.com/10879023/diff/1/ui/base/keycodes/keybo...
ui/base/keycodes/keyboard_codes_posix.h:212: VKEY_POWER = 0x98,
Running out of these... :-/

[mazda, 2012-08-22 23:03:14]

lgtm

http://codereview.chromium.org/10879023/diff/1/ui/base/keycodes/keyboard_code...
File ui/base/keycodes/keyboard_codes_posix.h (right):

http://codereview.chromium.org/10879023/diff/1/ui/base/keycodes/keyboard_code...
ui/base/keycodes/keyboard_codes_posix.h:212: VKEY_POWER = 0x98,
On 2012/08/22 22:20:47, Daniel Erat wrote:
> Running out of these... :-/

There are a few more unassigned values like 0x07, 0x40, 0x88 - 0x8F.
But anyway it's a matter of time to run out...
Do we plan to add more VKEY?

[Daniel Erat, 2012-08-22 23:09:29]

http://codereview.chromium.org/10879023/diff/1/ui/base/keycodes/keyboard_code...
File ui/base/keycodes/keyboard_codes_posix.h (right):

http://codereview.chromium.org/10879023/diff/1/ui/base/keycodes/keyboard_code...
ui/base/keycodes/keyboard_codes_posix.h:212: VKEY_POWER = 0x98,
On 2012/08/22 23:03:15, mazda wrote:
> On 2012/08/22 22:20:47, Daniel Erat wrote:
> > Running out of these... :-/
> 
> There are a few more unassigned values like 0x07, 0x40, 0x88 - 0x8F.
> But anyway it's a matter of time to run out...
> Do we plan to add more VKEY?

Maybe it's not a huge concern.  I think that we've covered all of the keys on
Chrome OS keyboards and most or all Internet/multimedia keys now. :-)

[commit-bot: I haz the power, 2012-08-22 23:10:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/10879023/1

[commit-bot: I haz the power, 2012-08-22 23:10:41]

Presubmit check for 10879023-1 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    ui/base/keycodes

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[Daniel Erat, 2012-08-22 23:22:30]

+sky for ui/

[sky, 2012-08-22 23:44:16]

LGTM

[commit-bot: I haz the power, 2012-08-22 23:46:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/10879023/1

[commit-bot: I haz the power, 2012-08-23 02:06:53]

Change committed as 152921