Issue 10879019: Fix atomicops internal implementation using GCC intrinsics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10879019: Fix atomicops internal implementation using GCC intrinsics. (Closed)

Created:
8 years, 4 months ago by bbudge

Modified:
8 years, 4 months ago

Reviewers:
brettw, jar (doing other things)

CC:
chromium-reviews, erikwright+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Fix atomicops internal implementation using GCC intrinsics. BUG=116317 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152833

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	base/atomicops_internals_gcc.h	View		1 chunk	+5 lines, -3 lines	0 comments	Download

Total messages: 6 (0 generated)

bbudge

Hi Jim, I think I may have broken this in the CL I just landed ...

8 years, 4 months ago (2012-08-22 20:45:43 UTC) #1

bbudge

On 2012/08/22 20:45:43, bbudge1 wrote: > Hi Jim, I think I may have broken this ...

8 years, 4 months ago (2012-08-22 20:58:48 UTC) #2

bbudge

On 2012/08/22 21:00:30, bbudge1 wrote: Rebasing CL. Also, here's the diff from the original code: ...

8 years, 4 months ago (2012-08-22 21:05:00 UTC) #4

bbudge

8 years, 4 months ago (2012-08-22 21:18:30 UTC) #6

On 2012/08/22 21:09:12, brettw wrote:
> lgtm

Rebaselining again.