lib/compiler/implementation/js_backend/emitter.dart - Issue 10879003: Const variables handled as final

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/js_backend/emitter.dart

Issue 10879003: Const variables handled as final (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Comment shortened Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/compiler/implementation/js_backend/emitter.dart

diff --git a/lib/compiler/implementation/js_backend/emitter.dart b/lib/compiler/implementation/js_backend/emitter.dart

index cb44ca9f7dcf5a0ba382594832b1e891ce25eb08..3dd2229ed9ea577e7249e6f20e7a9df8ebfa70bd 100644

--- a/lib/compiler/implementation/js_backend/emitter.dart

+++ b/lib/compiler/implementation/js_backend/emitter.dart

@@ -392,7 +392,7 @@ function(collectedClasses) {

bool instanceFieldNeedsSetter(Element member) {

assert(member.kind === ElementKind.FIELD);

- return (member.modifiers === null || !member.modifiers.isFinal())

+ return (member.modifiers === null || !member.modifiers.isFinalOrConst())

&& compiler.codegenWorld.hasInvokedSetter(member, compiler);

}