lib/compiler/implementation/compile_time_constants.dart - Issue 10879003: Const variables handled as final

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/compile_time_constants.dart

Issue 10879003: Const variables handled as final (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Comment shortened Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/compiler/implementation/compile_time_constants.dart

diff --git a/lib/compiler/implementation/compile_time_constants.dart b/lib/compiler/implementation/compile_time_constants.dart

index f2110bbd05a4b1ddc72766cfa5f3638d03c9e3ad..4b57f4e3447e8f84c49189e058066b9117c3853a 100644

--- a/lib/compiler/implementation/compile_time_constants.dart

+++ b/lib/compiler/implementation/compile_time_constants.dart

@@ -839,7 +839,8 @@ class CompileTimeConstantEvaluator extends AbstractVisitor {

Element element = elements[send];

if (Elements.isStaticOrTopLevelField(element)) {

if (element.modifiers === null ||

- !element.modifiers.isFinal()) {

+ // TODO(johnniwinther): This should eventually be [isConst].

+ !element.modifiers.isFinalOrConst()) {

error(send);

}

return compiler.compileVariable(element);