Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: webkit/fileapi/file_system_types.h

Issue 10879002: kFileSystemTypeIsolated should be only used in the URL exposed to renderer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: build fix Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/chromeos/fileapi/cros_mount_point_provider.cc ('k') | webkit/fileapi/file_system_url.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/fileapi/file_system_types.h
diff --git a/webkit/fileapi/file_system_types.h b/webkit/fileapi/file_system_types.h
index 936c81f4e2fe58fecbf460c00034bb4deedd8681..72d3ac44841410933cb52a363e13ccffba9e5679 100644
--- a/webkit/fileapi/file_system_types.h
+++ b/webkit/fileapi/file_system_types.h
@@ -13,6 +13,10 @@ enum FileSystemType {
// Indicates uninitialized or invalid filesystem type.
kFileSystemTypeUnknown = -1,
+ // ------------------------------------------------------------------------
+ // Public FileSystem types, that are embedded in filesystem: URL and exposed
+ // to WebKit/renderer. Both Chrome and WebKit know how to handle these types.
+
// Following two types are for TEMPORARY or PERSISTENT filesystems that
// can be used by webapps via standard app-facing API
// as defined in File API: Directories and System.
@@ -31,15 +35,21 @@ enum FileSystemType {
// This filesystem is used only by Chrome OS as of writing.
kFileSystemTypeExternal = WebKit::WebFileSystem::TypeExternal,
+ // ------------------------------------------------------------------------
+ // Private FileSystem types, that should not appear in filesystem: URL as
+ // WebKit has no idea how to handle those types.
+ //
+ // One can register (mount) a new file system with a private file system type
+ // using IsolatedContext. Files in such file systems can be accessed via
+ // either Isolated or External public file system types (depending on
+ // how the file system is registered).
+ // See the comments for IsolatedContext and/or FileSystemURL for more details.
+
// Should be used only for testing.
kFileSystemTypeTest = 100,
- // Following file system types are internal and they are not exposed to
- // WebKit, but are accessible via IsolatedContext.
-
- // Indicates a transient, isolated file system for a native local path.
- // TODO(kinuko): Rename all kFileSystemTypeIsolated used as internal type
- // with this one.
+ // Indicates a local filesystem where we can access files using native
+ // local path.
kFileSystemTypeNativeLocal,
// Indicates a transient, isolated file system for dragged files (which could
@@ -58,18 +68,6 @@ enum FileSystemType {
kFileSystemTypeDrive,
};
-enum FileSystemMountType {
- kFileSystemMountTypeUnknown = -1,
-
- // For kFileSystemTypeIsolated file systems. URLs for this type of
- // file system is cracked via IsolatedContext.
- kFileSystemMountTypeIsolated = kFileSystemTypeIsolated,
-
- // For kFileSystemTypeIsolated file systems. URLs for this type of
- // file system is cracked via IsolatedContext.
- kFileSystemMountTypeExternal = kFileSystemTypeExternal,
-};
-
} // namespace fileapi
#endif // WEBKIT_FILEAPI_FILE_SYSTEM_TYPES_H_
« no previous file with comments | « webkit/chromeos/fileapi/cros_mount_point_provider.cc ('k') | webkit/fileapi/file_system_url.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698