Issue 10879002: kFileSystemTypeIsolated should be only used in the URL exposed to renderer

Issue 10879002: kFileSystemTypeIsolated should be only used in the URL exposed to renderer (Closed)

Created:
8 years, 4 months ago by kinuko

Modified:
8 years, 3 months ago

Reviewers:
tzik

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, Aaron Boodman, pam+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, kinuko+watch

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

kFileSystemTypeIsolated should be only used in the URL exposed to renderer Also added verbose description in file_system_types.h. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153498

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 2

Patch Set 3 : nits fix #

Patch Set 4 : rebase + nit fix #

Patch Set 5 : build fix #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -55 lines)			Patch
M	chrome/browser/extensions/api/file_system/file_system_api.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/platform_app_launcher.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/extensions/file_system_natives.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	content/browser/fileapi/fileapi_message_filter.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/chromeos/fileapi/cros_mount_point_provider.cc	View	1 2 3 4	3 chunks	+7 lines, -6 lines	0 comments	Download
M	webkit/fileapi/file_system_types.h	View	1 2 3	3 chunks	+16 lines, -18 lines	0 comments	Download
M	webkit/fileapi/file_system_url.h	View	1 2 3	4 chunks	+6 lines, -5 lines	0 comments	Download
M	webkit/fileapi/file_system_url.cc	View	1 2 3	2 chunks	+2 lines, -4 lines	0 comments	Download
M	webkit/fileapi/file_system_util.h	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	webkit/fileapi/isolated_context.cc	View	1 2 3	8 chunks	+9 lines, -9 lines	0 comments	Download
M	webkit/fileapi/isolated_context_unittest.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	webkit/fileapi/isolated_mount_point_provider.cc	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/tools/test_shell/simple_file_system.cc	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/tools/test_shell/simple_file_writer.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kinuko

http://codereview.chromium.org/10879002/diff/3011/webkit/fileapi/file_system_util.h File webkit/fileapi/file_system_util.h (right): http://codereview.chromium.org/10879002/diff/3011/webkit/fileapi/file_system_util.h#newcode70 webkit/fileapi/file_system_util.h:70: // |type| needs to be public type as the ...

8 years, 4 months ago (2012-08-22 08:23:56 UTC) #1

lgtm

Expand Messages | Collapse Messages