Issue 10878085: Change default values of some gesture related constants

Issue 10878085: Change default values of some gesture related constants (Closed)

Created:
8 years, 3 months ago by varunjain

Modified:
8 years, 3 months ago

Reviewers:
sadrul, sky

CC:
chromium-reviews, arv (Not doing code reviews), sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Change default values of some gesture related constants BUG=139650, 145059 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153634

Patch Set 3 : patch #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -22 lines)			Patch
M	chrome/browser/resources/gesture_config.js	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/browser/ui/gesture_prefs_observer_factory_aura.cc	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/common/pref_names.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/pref_names.cc	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/aura/gestures/gesture_recognizer_unittest.cc	View	1	8 chunks	+15 lines, -15 lines	0 comments	Download
M	ui/aura/test/aura_test_base.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	ui/base/gestures/gesture_configuration.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	ui/base/gestures/gesture_configuration.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	ui/base/gestures/gesture_point.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://chromiumcodereview.appspot.com/10878085/diff/2001/chrome/common/pref_names.h File chrome/common/pref_names.h (right): https://chromiumcodereview.appspot.com/10878085/diff/2001/chrome/common/pref_names.h#newcode716 chrome/common/pref_names.h:716: extern const char kMaxDistanceBetweenTapsForDoubleTap[]; sort

8 years, 3 months ago (2012-08-28 00:08:46 UTC) #2

varunjain

https://chromiumcodereview.appspot.com/10878085/diff/2001/chrome/common/pref_names.h File chrome/common/pref_names.h (right): https://chromiumcodereview.appspot.com/10878085/diff/2001/chrome/common/pref_names.h#newcode716 chrome/common/pref_names.h:716: extern const char kMaxDistanceBetweenTapsForDoubleTap[]; On 2012/08/28 00:08:46, sky wrote: ...

8 years, 3 months ago (2012-08-28 03:05:36 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/10878085/11001

8 years, 3 months ago (2012-08-28 03:05:50 UTC) #4

Change committed as 153634

Expand Messages | Collapse Messages