Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 10878082: net: Move file operation code from UploadData to UploadDataStream (Closed)

Created:
8 years, 3 months ago by hashimoto
Modified:
8 years, 3 months ago
CC:
chromium-reviews, pam+watch_chromium.org, cbentzel+watch_chromium.org, grt+watch_chromium.org, amit, jam, joi+watch-content_chromium.org, robertshield, darin-cc_chromium.org, satorux1, kinuko
Visibility:
Public.

Description

net: Move file operation code from UploadData to UploadDataStream ResetOffset(), GetContentLength() and IsInMemory() are moved from UploadData to UploadDataStream. This is an intermediate step to make simlar change to UploadElement BUG=72001 TEST=net_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154594

Patch Set 1 : _ #

Total comments: 1

Patch Set 2 : Fix Chrome Frame #

Patch Set 3 : Move IsInMemory() #

Patch Set 4 : Remove initialization check from IsInMemory #

Total comments: 3

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -288 lines) Patch
M chrome_frame/plugin_url_request.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome_frame/urlmon_upload_data_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/upload_data.h View 1 2 3 chunks +0 lines, -26 lines 0 comments Download
M net/base/upload_data.cc View 1 2 2 chunks +0 lines, -59 lines 0 comments Download
M net/base/upload_data_stream.cc View 1 2 3 4 chunks +23 lines, -8 lines 0 comments Download
M net/base/upload_data_stream_unittest.cc View 6 chunks +89 lines, -3 lines 0 comments Download
M net/base/upload_data_unittest.cc View 1 2 1 chunk +0 lines, -169 lines 0 comments Download
M net/http/http_network_transaction_spdy2_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_network_transaction_spdy3_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/net.gyp View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/spdy_network_transaction_spdy2_unittest.cc View 2 chunks +5 lines, -9 lines 0 comments Download
M net/spdy/spdy_network_transaction_spdy3_unittest.cc View 2 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hashimoto
Will, Could you review this change? This change is a preparation for removing file operation ...
8 years, 3 months ago (2012-08-27 22:09:40 UTC) #1
willchan no longer on Chromium
http://codereview.chromium.org/10878082/diff/18002/content/browser/renderer_host/resource_dispatcher_host_impl.cc File content/browser/renderer_host/resource_dispatcher_host_impl.cc (right): http://codereview.chromium.org/10878082/diff/18002/content/browser/renderer_host/resource_dispatcher_host_impl.cc#newcode969 content/browser/renderer_host/resource_dispatcher_host_impl.cc:969: if (upload_stream.Init() == net::OK) I'm concerned about calling Init() ...
8 years, 3 months ago (2012-08-28 23:45:22 UTC) #2
hashimoto
http://codereview.chromium.org/10878082/diff/18002/content/browser/renderer_host/resource_dispatcher_host_impl.cc File content/browser/renderer_host/resource_dispatcher_host_impl.cc (right): http://codereview.chromium.org/10878082/diff/18002/content/browser/renderer_host/resource_dispatcher_host_impl.cc#newcode969 content/browser/renderer_host/resource_dispatcher_host_impl.cc:969: if (upload_stream.Init() == net::OK) On 2012/08/28 23:45:22, willchan wrote: ...
8 years, 3 months ago (2012-08-28 23:49:56 UTC) #3
willchan no longer on Chromium
http://codereview.chromium.org/10878082/diff/18002/content/browser/renderer_host/resource_dispatcher_host_impl.cc File content/browser/renderer_host/resource_dispatcher_host_impl.cc (right): http://codereview.chromium.org/10878082/diff/18002/content/browser/renderer_host/resource_dispatcher_host_impl.cc#newcode969 content/browser/renderer_host/resource_dispatcher_host_impl.cc:969: if (upload_stream.Init() == net::OK) On 2012/08/28 23:49:56, hashimoto wrote: ...
8 years, 3 months ago (2012-08-28 23:59:36 UTC) #4
hashimoto
On 2012/08/28 23:59:36, willchan wrote: > http://codereview.chromium.org/10878082/diff/18002/content/browser/renderer_host/resource_dispatcher_host_impl.cc > File content/browser/renderer_host/resource_dispatcher_host_impl.cc (right): > > http://codereview.chromium.org/10878082/diff/18002/content/browser/renderer_host/resource_dispatcher_host_impl.cc#newcode969 > ...
8 years, 3 months ago (2012-08-30 23:13:31 UTC) #5
willchan no longer on Chromium
LGTM
8 years, 3 months ago (2012-09-01 00:12:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10878082/29002
8 years, 3 months ago (2012-09-01 00:13:13 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-01 03:46:07 UTC) #8
Change committed as 154594

Powered by Google App Engine
This is Rietveld 408576698