Issue 10878079: Changes workspace code to only move windows when the work area changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10878079: Changes workspace code to only move windows when the work area changes (Closed)

Created:
8 years, 3 months ago by sky

Modified:
8 years, 3 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Changes workspace code to only move windows when the work area changes and the workspace is active. Without this a workspace switch (such as going from normal to maximized) causes windows to move back onscreen as the work area changes as a result of shelf visibility changing. BUG=137342 TEST=none R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153528

Patch Set 1 #

Patch Set 2 : Remove include #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -9 lines)			Patch
M	ash/wm/workspace/workspace_layout_manager2.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	ash/wm/workspace/workspace_layout_manager2.cc	View	1	5 chunks	+14 lines, -9 lines	0 comments	Download
M	ash/wm/workspace/workspace_manager2_unittest.cc	View		1 chunk	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/10878079/2001

8 years, 3 months ago (2012-08-27 16:00:37 UTC) #3

Change committed as 153528

Expand Messages | Collapse Messages