Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 10878074: Adds if !defined(OS_IOS) around body of CreateTestRenderViewHosts. (Closed)

Created:
8 years, 3 months ago by leng
Modified:
8 years, 3 months ago
Reviewers:
stuartmorgan, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Adds if !defined(OS_IOS) around body of CreateTestRenderViewHosts. The classes content::MockRenderProcessHostFactory and TestRenderViewHostFactory do not exist on iOS; they would not make sense on iOS. BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153549

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/public/test/test_content_client_initializer.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
leng
8 years, 3 months ago (2012-08-27 09:24:35 UTC) #1
stuartmorgan
LGTM +jam for owners John, we've mostly been opting for stubs instead of ifdefs, but ...
8 years, 3 months ago (2012-08-27 09:58:35 UTC) #2
jam
lgtm
8 years, 3 months ago (2012-08-27 17:06:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leng@chromium.org/10878074/1
8 years, 3 months ago (2012-08-27 19:50:00 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-08-27 21:30:48 UTC) #5
Change committed as 153549

Powered by Google App Engine
This is Rietveld 408576698