Move STARTUPINFO manipulation into SpawnTarget

Move STARTUPINFO manipulation into SpawnTarget
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153606

[jschuh, 2012-08-26 00:00:24]

Depends on: http://codereview.chromium.org/10870093/

I decide not to move this out of base, because we really will need it outside
the sandbox (e.g. handle inheritance for pending IPC changes). So, it makes
sense to keep it there.

[rvargas (doing something else), 2012-08-27 17:56:22]

lgtm

http://codereview.chromium.org/10878071/diff/3002/sandbox/win/src/broker_serv...
File sandbox/win/src/broker_services.cc (right):

http://codereview.chromium.org/10878071/diff/3002/sandbox/win/src/broker_serv...
sandbox/win/src/broker_services.cc:320: startup_info.startup_info()->lpDesktop =
This is not really related with this CL, but I think we should not use this
pattern (provide a general purpose writable accessor for an object).

We should have a dedicated setter.

http://codereview.chromium.org/10878071/diff/3002/sandbox/win/src/target_proc...
File sandbox/win/src/target_process.h (right):

http://codereview.chromium.org/10878071/diff/3002/sandbox/win/src/target_proc...
sandbox/win/src/target_process.h:14: #include "base/win/startup_information.h"
nit: forward declare

http://codereview.chromium.org/10878071/diff/3002/sandbox/win/src/target_proc...
sandbox/win/src/target_process.h:42: base::win::StartupInformation*
startup_info,
const SI& (preferred)? or const SI*

[jschuh, 2012-08-27 19:10:19]

http://codereview.chromium.org/10878071/diff/3002/sandbox/win/src/broker_serv...
File sandbox/win/src/broker_services.cc (right):

http://codereview.chromium.org/10878071/diff/3002/sandbox/win/src/broker_serv...
sandbox/win/src/broker_services.cc:320: startup_info.startup_info()->lpDesktop =
On 2012/08/27 17:56:22, rvargas wrote:
> This is not really related with this CL, but I think we should not use this
> pattern (provide a general purpose writable accessor for an object).
> 
> We should have a dedicated setter.

You're right; I was lazy the first time around. I'll write the accessors in a
follow-up and then remove the non-const startup_info accessor.

http://codereview.chromium.org/10878071/diff/3002/sandbox/win/src/target_proc...
File sandbox/win/src/target_process.h (right):

http://codereview.chromium.org/10878071/diff/3002/sandbox/win/src/target_proc...
sandbox/win/src/target_process.h:14: #include "base/win/startup_information.h"
On 2012/08/27 17:56:22, rvargas wrote:
> nit: forward declare

Done.

http://codereview.chromium.org/10878071/diff/3002/sandbox/win/src/target_proc...
sandbox/win/src/target_process.h:42: base::win::StartupInformation*
startup_info,
On 2012/08/27 17:56:22, rvargas wrote:
> const SI& (preferred)? or const SI*

Done.

[commit-bot: I haz the power, 2012-08-28 01:22:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jschuh@chromium.org/10878071/2002