Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 10878061: chromeos: Move src/chrome/browser/chromeos/cryptohome to src/chromeos (Closed)

Created:
8 years, 4 months ago by hashimoto
Modified:
8 years, 3 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

chromeos: Move src/chrome/browser/chromeos/cryptohome to src/chromeos BUG=None TEST=build TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153410

Patch Set 1 : _ #

Total comments: 2

Patch Set 2 : Removed a blank line #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -383 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/cryptohome/async_method_caller.h View 1 chunk +0 lines, -86 lines 0 comments Download
D chrome/browser/chromeos/cryptohome/async_method_caller.cc View 1 chunk +0 lines, -183 lines 0 comments Download
D chrome/browser/chromeos/cryptohome/mock_async_method_caller.h View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/browser/chromeos/cryptohome/mock_async_method_caller.cc View 1 chunk +0 lines, -44 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/parallel_authenticator.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/parallel_authenticator_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/chromeos.gyp View 2 chunks +4 lines, -0 lines 0 comments Download
A + chromeos/cryptohome/async_method_caller.h View 3 chunks +6 lines, -5 lines 0 comments Download
A + chromeos/cryptohome/async_method_caller.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chromeos/cryptohome/mock_async_method_caller.h View 2 chunks +5 lines, -4 lines 0 comments Download
A + chromeos/cryptohome/mock_async_method_caller.cc View 1 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
hashimoto
oshima, Could you take a look?
8 years, 4 months ago (2012-08-24 20:36:37 UTC) #1
oshima
lgtm http://codereview.chromium.org/10878061/diff/1001/chromeos/cryptohome/mock_async_method_caller.cc File chromeos/cryptohome/mock_async_method_caller.cc (right): http://codereview.chromium.org/10878061/diff/1001/chromeos/cryptohome/mock_async_method_caller.cc#newcode42 chromeos/cryptohome/mock_async_method_caller.cc:42: not your fault, but can you remove extra ...
8 years, 4 months ago (2012-08-25 00:32:24 UTC) #2
hashimoto
http://codereview.chromium.org/10878061/diff/1001/chromeos/cryptohome/mock_async_method_caller.cc File chromeos/cryptohome/mock_async_method_caller.cc (right): http://codereview.chromium.org/10878061/diff/1001/chromeos/cryptohome/mock_async_method_caller.cc#newcode42 chromeos/cryptohome/mock_async_method_caller.cc:42: On 2012/08/25 00:32:25, oshima wrote: > not your fault, ...
8 years, 4 months ago (2012-08-25 00:42:59 UTC) #3
hashimoto
TBR-ing ben@ for gyp changes
8 years, 4 months ago (2012-08-25 00:46:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10878061/4002
8 years, 4 months ago (2012-08-25 00:47:30 UTC) #5
commit-bot: I haz the power
Failed to apply patch for chrome/browser/chromeos/login/user_manager_impl.cc: While running patch -p1 --forward --force; patching file chrome/browser/chromeos/login/user_manager_impl.cc ...
8 years, 4 months ago (2012-08-25 00:47:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10878061/2018
8 years, 4 months ago (2012-08-25 03:37:08 UTC) #7
commit-bot: I haz the power
Change committed as 153410
8 years, 3 months ago (2012-08-26 12:11:39 UTC) #8
Ben Goodger (Google)
lgtm
8 years, 3 months ago (2012-08-27 15:47:12 UTC) #9
tfarina
8 years, 3 months ago (2012-08-30 03:09:46 UTC) #10
On 2012/08/27 15:47:12, Ben Goodger (Google) wrote:
> lgtm

doesn't this work has a bug filed on crbug.com/? if so, in future CLs, can you
include the number in BUG= line? thanks.

Powered by Google App Engine
This is Rietveld 408576698