Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Unified Diff: chrome/browser/extensions/data_deleter.cc

Issue 10878041: Remove silly uses of ResourceContext that unnecessarily violate the Law of Demeter. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: only the IO thread may grab the controller. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/data_deleter.cc
diff --git a/chrome/browser/extensions/data_deleter.cc b/chrome/browser/extensions/data_deleter.cc
index 81f3d404c2ac4ed4106d53d0e87e8dc394a92d55..0abe1e0eee89c4d930b64a1e85402a4af9a15ac7 100644
--- a/chrome/browser/extensions/data_deleter.cc
+++ b/chrome/browser/extensions/data_deleter.cc
@@ -14,7 +14,6 @@
#include "chrome/common/url_constants.h"
#include "content/public/browser/dom_storage_context.h"
#include "content/public/browser/indexed_db_context.h"
-#include "content/public/browser/resource_context.h"
#include "content/public/browser/storage_partition.h"
#include "net/base/completion_callback.h"
#include "net/base/net_errors.h"
@@ -30,7 +29,6 @@ using content::BrowserContext;
using content::BrowserThread;
using content::DOMStorageContext;
using content::IndexedDBContext;
-using content::ResourceContext;
namespace extensions {
@@ -70,7 +68,8 @@ void DataDeleter::StartDeleting(Profile* profile,
BrowserThread::IO, FROM_HERE,
base::Bind(&DataDeleter::DeleteAppcachesOnIOThread,
deleter,
- profile->GetResourceContext()));
+ BrowserContext::GetDefaultStoragePartition(profile)->
+ GetAppCacheService()));
profile->GetExtensionService()->settings_frontend()->
DeleteStorageSoon(extension_id);
@@ -138,10 +137,11 @@ void DataDeleter::DeleteFileSystemOnFileThread() {
file_util::Delete(isolated_app_path_, true);
}
-void DataDeleter::DeleteAppcachesOnIOThread(ResourceContext* context) {
+void DataDeleter::DeleteAppcachesOnIOThread(
+ appcache::AppCacheService* appcache_service) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
- ResourceContext::GetAppCacheService(context)->DeleteAppCachesForOrigin(
- storage_origin_, net::CompletionCallback());
+ appcache_service->DeleteAppCachesForOrigin(storage_origin_,
+ net::CompletionCallback());
}
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698