Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4528)

Unified Diff: chrome/renderer/resources/extensions/app_window_custom_bindings.js

Issue 10878040: Move context-sensitive app.window.* functions to app.window.current().* (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/app_window_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/app_window_custom_bindings.js b/chrome/renderer/resources/extensions/app_window_custom_bindings.js
index ed430be286df5698911eb2394a619b402ff1515a..244f70dbd77294a8d39f7cd399a675e1a8b5418b 100644
--- a/chrome/renderer/resources/extensions/app_window_custom_bindings.js
+++ b/chrome/renderer/resources/extensions/app_window_custom_bindings.js
@@ -16,14 +16,16 @@ chromeHidden.registerCustomHook('app.window', function(bindingsAPI) {
if (viewId)
view = GetView(viewId);
if (request.callback) {
- request.callback(view);
+ request.callback(view.chrome.app.window.current());
delete request.callback;
}
})
- apiFunctions.setHandleRequest('moveTo', function(x, y) {
- window.moveTo(x, y);
- })
- apiFunctions.setHandleRequest('resizeTo', function(width, height) {
- window.resizeTo(width, height);
+ var AppWindow = function() {};
+ for (var fn in chromeHidden.internalAPIs.app.currentWindow) {
+ console.log(fn);
Mihai Parparita -not on Chrome 2012/08/24 01:05:07 Remove log statement before committing.
jeremya 2012/08/24 02:10:08 Done.
+ AppWindow.prototype[fn] = chromeHidden.internalAPIs.app.currentWindow[fn];
+ }
+ apiFunctions.setHandleRequest('current', function() {
+ return new AppWindow;
})
});

Powered by Google App Engine
This is Rietveld 408576698