Move context-sensitive app.window.* functions to app.window.current().*

chrome/renderer/resources/extensions/app_window_custom_bindings.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Custom bindings for the app_window API.
 
 var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
 var sendRequest = require('sendRequest').sendRequest;
 var appWindowNatives = requireNative('app_window');
 var GetView = appWindowNatives.GetView;
 
 chromeHidden.registerCustomHook('app.window', function(bindingsAPI) {
   var apiFunctions = bindingsAPI.apiFunctions;
   apiFunctions.setCustomCallback('create', function(name, request, viewId) {
     var view = null;
     if (viewId)
       view = GetView(viewId);
     if (request.callback) {
-      request.callback(view);
+      request.callback(view.chrome.app.window.current());
       delete request.callback;
     }
   })
-  apiFunctions.setHandleRequest('moveTo', function(x, y) {
-    window.moveTo(x, y);
-  })
-  apiFunctions.setHandleRequest('resizeTo', function(width, height) {
-    window.resizeTo(width, height);
+  var AppWindow = function() {};
+  for (var fn in chromeHidden.internalAPIs.app.currentWindowInternal) {

[not at google - send to devlin, 2012/08/27 01:51:59]

loops with "foo in bar" should be protected by hasOwnProperty. There is a util
function for this (forEach) in util.js.

[jeremya, 2012/08/30 02:38:54]

Done.

+    AppWindow.prototype[fn] =
+        chromeHidden.internalAPIs.app.currentWindowInternal[fn];
+  }
+  AppWindow.prototype.moveTo = window.moveTo.bind(window);
+  AppWindow.prototype.resizeTo = window.resizeTo.bind(window);
+  AppWindow.prototype.__defineGetter__('dom', function () { return window; });

[not at google - send to devlin, 2012/08/27 01:51:59]

what's the advantage of making this a getter over just a property?

[jeremya, 2012/08/30 02:38:54]

... don't know :) changed to a property.

+  apiFunctions.setHandleRequest('current', function() {
+    return new AppWindow;
   })
 });